Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tx Flow] Messages and the Transaction Status block #2384

Closed
francovenica opened this issue Aug 11, 2023 · 0 comments · Fixed by #2415
Closed

[Tx Flow] Messages and the Transaction Status block #2384

francovenica opened this issue Aug 11, 2023 · 0 comments · Fixed by #2415
Assignees
Labels
bug Something isn't working

Comments

@francovenica
Copy link
Contributor

Bug description

For messages, the tx status block on the right side is misplaced: is not a transaction, the confirmation there never changes, and it does not executes.

Environment

  • Browser: Chrome
  • Wallet: any
  • Chain: any (but tested in goerli)
  • Env: Prod 1.16

Steps to reproduce

  1. Clone this repo and open the application https://github.com/5afe/eip-1271-dapp
  2. Open a safe you own. Open the wallet connect Dapp in the safe
  3. Use the "Connect" in the eip1271 app and copy/paste the WC code from the modal in the safe WC Dapp
  4. In the eip1271 enable off-chain sigature, write any message and send
  5. In the safe, it should now show the form to sign the message

Expected result

I'd suggest making it work with the same counter that is in the bottom of the form or remove the block completely

Obtained result

The snapshot

Screenshots

08-10-2023_1247x578(6338)

@francovenica francovenica added the bug Something isn't working label Aug 11, 2023
@github-project-automation github-project-automation bot moved this to New issues in Web Squad Aug 11, 2023
@katspaugh katspaugh moved this from New issues to Todo in Web Squad Aug 14, 2023
@katspaugh katspaugh self-assigned this Aug 17, 2023
@katspaugh katspaugh moved this from Todo to In Progress in Web Squad Aug 17, 2023
@katspaugh katspaugh moved this from In Progress to Peer Review in Web Squad Aug 17, 2023
@katspaugh katspaugh moved this from Peer Review to Ready for QA in Web Squad Aug 17, 2023
@francovenica francovenica moved this from Ready for QA to QA in progress in Web Squad Aug 17, 2023
@francovenica francovenica moved this from QA in progress to QA done in Web Squad Aug 17, 2023
@github-project-automation github-project-automation bot moved this from QA done to Done in Web Squad Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants