Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: status widget for 1271 messages #2415

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Fix: status widget for 1271 messages #2415

merged 1 commit into from
Aug 17, 2023

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #2384

When signing a message, it will say "Message status" instead of "Transaction status".

Screenshot 2023-08-17 at 12 04 09

@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Branch preview

✅ Deploy successful!

https://message_status--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

LGTM

It looks like the snapshot in the tickets description.

@francovenica francovenica reopened this Aug 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2023
@francovenica
Copy link
Contributor

Sorry, missclicked when closing it. I reopened it. Moving it to QA done

@katspaugh katspaugh merged commit 1d5838c into dev Aug 17, 2023
10 of 13 checks passed
@katspaugh katspaugh deleted the message-status branch August 17, 2023 16:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tx Flow] Messages and the Transaction Status block
3 participants