Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show copy/explorer buttons on load review #1058

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Nov 4, 2022

What it solves

Resolves #1056

How this PR fixes it

The copy and explorer buttons are now shown next to addresses of the Safe-to-be-added on the review step of the add Safe flow.

How to test it

Add a Safe and on the review step, observe the copy and explorer buttons next to the Safe/owners.

Screenshots

image

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 4, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 70b305d
Status: ✅  Deploy successful!
Preview URL: https://be99917c.web-core.pages.dev
Branch Preview URL: https://add-safe-ethhashinfo.web-core.pages.dev

View logs

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katspaugh
Copy link
Member

The Safe address should also have them.

Copy link
Member

@DiogoSoaress DiogoSoaress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iamacook iamacook merged commit b32a99d into dev Nov 4, 2022
@iamacook iamacook deleted the add-safe-ethhashinfo branch November 4, 2022 13:55
@katspaugh katspaugh mentioned this pull request Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Soft Release] copy to clipboard and block explorer buttons missing in Add safe
3 participants