Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update protobufjs transitive dependency #2255

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix: update protobufjs transitive dependency #2255

merged 1 commit into from
Jul 11, 2023

Conversation

schmanu
Copy link
Member

@schmanu schmanu commented Jul 10, 2023 •
edited
Loading

What it solves

Updates protobufjs

How to test it

  • Test if trezor wallet still works

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@schmanu schmanu requested a review from iamacook July 10, 2023 08:57
@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited
Loading

Branch preview

✅ Deploy successful!

https://fix_protobuf--walletweb.review-wallet-web.5afe.dev

@schmanu schmanu changed the title fix: resolve third party dependency fix: update protobufjs 3rd party dependency Jul 10, 2023
@schmanu schmanu changed the title fix: update protobufjs 3rd party dependency fix: update protobufjs transitive dependency Jul 10, 2023
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@iamacook
Copy link
Member

For context, this is regarding this warning.

iamacook
iamacook approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Transactions are working as expected.

@francovenica
Copy link
Contributor

LGTM
I tested with a Trezor One

I was able to create a safe and edit owners just fine in goerli.

@schmanu schmanu merged commit ad2e574 into dev Jul 11, 2023
@schmanu schmanu deleted the fix-protobuf branch July 11, 2023 08:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iamacook iamacook iamacook approved these changes

@usame-algan usame-algan usame-algan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Web Squad
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmanu @iamacook @francovenica @usame-algan