-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replacement nonce dropdown style #2318
Conversation
Branch preview✅ Deploy successful! https://nonce_replacement_style--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we also add the current Safe nonce to the drop-down? Has that been discussed? At least for the case where the recommended one differs from the current Safe nonce.
@schmanu in what situation do you think it could be helpful? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What it solves
Resolves #2304
How this PR fixes it
The design of the replacement nonce dropdown has been aligned with the designs.
How to test it
Opent the transaction flow on a Safe and observe the recommended nonce in the dropdown list (as well as other queued transactions, if they exist).
Screenshots
Checklist