Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replacement nonce dropdown style #2318

Merged
merged 3 commits into from
Jul 31, 2023
Merged

fix: replacement nonce dropdown style #2318

merged 3 commits into from
Jul 31, 2023

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jul 27, 2023

What it solves

Resolves #2304

How this PR fixes it

The design of the replacement nonce dropdown has been aligned with the designs.

How to test it

Opent the transaction flow on a Safe and observe the recommended nonce in the dropdown list (as well as other queued transactions, if they exist).

Screenshots

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Jul 27, 2023
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

Branch preview

✅ Deploy successful!

https://nonce_replacement_style--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 27, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh
Copy link
Member

Seems like the paddings are a bit too big.
Screenshot 2023-07-27 at 16 11 58

@iamacook iamacook marked this pull request as draft July 27, 2023 14:14
@iamacook iamacook marked this pull request as ready for review July 27, 2023 17:30
Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we also add the current Safe nonce to the drop-down? Has that been discussed? At least for the case where the recommended one differs from the current Safe nonce.

@katspaugh
Copy link
Member

@schmanu in what situation do you think it could be helpful?

@katspaugh
Copy link
Member

The top padding is still too big. It should be the same as the left-right padding:
Screenshot 2023-07-31 at 08 25 39

@iamacook
Copy link
Member Author

The top padding is still too big. It should be the same as the left-right padding: Screenshot 2023-07-31 at 08 25 39

Oversight working from the airport. I've reduced the y-axis padding.

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@francovenica
Copy link
Contributor

Looks neat.
image

@iamacook iamacook merged commit 793cd98 into dev Jul 31, 2023
7 checks passed
@iamacook iamacook deleted the nonce-replacement-style branch July 31, 2023 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tx flow] Update transaction replacement dropdown style
4 participants