Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: show delegates #2324

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Feat: show delegates #2324

merged 3 commits into from
Aug 2, 2023

Conversation

katspaugh
Copy link
Member

What it solves

It's currently not possible to see from the UI if a Safe Account has delegates attached (addresses that can only create transactions).

This PR just shows the list of delegates if they are enabled.

Screenshot 2023-07-28 at 12 36 01

@github-actions
Copy link

github-actions bot commented Jul 28, 2023

Branch preview

✅ Deploy successful!

https://delegates--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Jul 28, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@katspaugh katspaugh requested a review from iamacook July 28, 2023 10:51
Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a short description of what a "delegated account" is as we do with other settings.

@katspaugh
Copy link
Member Author

@iamacook I've added a tooltip and a link to the help portal.

Screenshot 2023-07-31 at 11 14 59

@francovenica
Copy link
Contributor

LGTM.
Thanks @usame-algan For the help

We used this app https://github.com/Soptq/gnosis-safe-delegate-dapp locally to add a delegate to the safe and check.

The delegates are listed and the block is hidden if there are no delegates.
image

@katspaugh katspaugh merged commit 1db9568 into dev Aug 2, 2023
7 checks passed
@katspaugh katspaugh deleted the delegates branch August 2, 2023 19:32
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants