Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "Transaction is executed" to stepper #2328

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

iamacook
Copy link
Member

What it solves

Resolves #2300

How this PR fixes it

A new "Transaction is executed" step has been added to the success screen of the new transaciton flow according to the desings.

How to test it

Create and execute a transaction, observing the new step.

Screenshots

executed-step

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from schmanu July 31, 2023 08:38
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

Branch preview

✅ Deploy successful!

https://transaction_executed--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

LGTM

@iamacook iamacook merged commit c031735 into dev Jul 31, 2023
@iamacook iamacook deleted the transaction-executed branch July 31, 2023 11:14
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tx flow] "Transaction is executed" status missing in the last step
3 participants