Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't close flow in Safe Apps #2333

Merged
merged 2 commits into from
Aug 1, 2023
Merged

fix: don't close flow in Safe Apps #2333

merged 2 commits into from
Aug 1, 2023

Conversation

iamacook
Copy link
Member

What it solves

Resolves #2286

How this PR fixes it

The Safe App transaction flow is no longer closed via the communicator.

How to test it

Observe that the Safe App transaction flow closes in the following instances:

  • Queuing a transaction
  • Successfully preparing an off-chain signature

Observe that the Safe App transaction flow doesn't close in the following instance:

  • Executing a transaction

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from schmanu July 31, 2023 14:16
@iamacook iamacook self-assigned this Jul 31, 2023
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

Branch preview

✅ Deploy successful!

https://safe_apps_close--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@francovenica
Copy link
Contributor

LGTM

Adding tx to the queue as just signed but not executed keeps the app open
Creating and executing a tx right away shows the same workflow as executing any other tx.

@iamacook iamacook merged commit 1a48103 into dev Aug 1, 2023
7 checks passed
@iamacook iamacook deleted the safe-apps-close branch August 1, 2023 07:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tx flow] Safe Apps close the success screen
3 participants