Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: clear batch on confirm #2382

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Fix: clear batch on confirm #2382

merged 1 commit into from
Aug 11, 2023

Conversation

katspaugh
Copy link
Member

What it solves

When a batch is confirmed, it should be removed. It didn't work because I was passing the wrong id.

How to test it

  • Create a batch
  • Confirm it
  • It should be proposed to the queue (or executed)
  • It should disappear from the batch sidebar

@github-actions
Copy link

github-actions bot commented Aug 10, 2023

Branch preview

✅ Deploy successful!

https://fix_batch_clear--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to get the fix out

But let's add a test for the BatchSidebar logic soon.

@francovenica
Copy link
Contributor

LGTM.
Now once the tx batched is proposed (whatever is just confirmation or execution) the batch list is cleared.

Note: I thought leaving it there would prompt us to someday give the option to export the batch as a csv, but we can think about that in a future iteration.

@katspaugh katspaugh merged commit 0350c35 into dev Aug 11, 2023
6 of 7 checks passed
@katspaugh katspaugh deleted the fix-batch-clear branch August 11, 2023 06:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants