Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [mobile] CSS for not connected state in header #2387

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

katspaugh
Copy link
Member

What it solves

Resolves #2380

Not connected:
Screenshot 2023-08-11 at 12 14 58

Connected:
Screenshot 2023-08-11 at 12 13 31

@github-actions
Copy link

github-actions bot commented Aug 11, 2023

Branch preview

✅ Deploy successful!

https://fix_mobile--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I tested it whilst not connected and it looks good:

image

as well as when connected:

image

@katspaugh katspaugh merged commit be09d8d into dev Aug 11, 2023
6 of 7 checks passed
@katspaugh katspaugh deleted the fix-mobile branch August 11, 2023 10:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top bar mobile web browsing - Network icon goes out of bounds
2 participants