fix: don't over-poll Spending Limits data #2407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Reduces
eth_call
requestsHow this PR fixes it
The
length
of themodules
array is checked instead of the array itself when requesting spending limit details inuseLoadSpendingLimits
.useAsync
linting changed thesafe.modules
length
dependency in favour ofsafe.modules
. This caused the increase ofeth_call
requests as a new instance of the Safe info is returned every poll due to theloading
flag inuseSafeInfo
.How to test it
Open a Safe with spending limits enabled and observe a reduced number of
eth_call
s when compared to prod.Checklist