Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get Safe address on-chain for ZK creations #2416

Merged
merged 7 commits into from
Aug 18, 2023
Merged

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Aug 17, 2023

What it solves

Resolves #2370

How this PR fixes it

This updates the @safe-global/safe-core-sdk to 3.3.5 as per requested which fixes Safe address prediction on ZK chains.

How to test it

Create a Safe on a ZK chain and observe the correct Safe address in the creation stepper/navigation link after indexed.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook requested a review from schmanu August 17, 2023 10:52
@iamacook iamacook self-assigned this Aug 17, 2023
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Branch preview

✅ Deploy successful!

https://zk_address_prediction--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Aug 17, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook requested a review from schmanu August 17, 2023 12:34
@francovenica
Copy link
Contributor

Looks good.
The address shown during the safe creation process is the same as the safe after being created:
image
image
image

@francovenica
Copy link
Contributor

@iamacook Since @schmanu requested a change I'll not pass the ticket to QA done yet. Let me know if that change requieres a re-test.

@katspaugh katspaugh dismissed schmanu’s stale review August 18, 2023 16:59

It was for a previous version

@katspaugh katspaugh merged commit 97bb344 into dev Aug 18, 2023
7 checks passed
@katspaugh katspaugh deleted the zk-address-prediction branch August 18, 2023 17:23
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Safe creation] Predicted Safe address is wrong on zkSync
5 participants