-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get Safe address on-chain for ZK creations #2416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deploy successful! https://zk_address_prediction--walletweb.review-wallet-web.5afe.dev |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Aug 17, 2023
src/components/new-safe/create/steps/StatusStep/useIsZkEvmChain.ts
Outdated
Show resolved
Hide resolved
3 tasks
schmanu
previously requested changes
Aug 17, 2023
src/components/new-safe/create/steps/StatusStep/StatusStepper.tsx
Outdated
Show resolved
Hide resolved
src/components/new-safe/create/steps/StatusStep/StatusStepper.tsx
Outdated
Show resolved
Hide resolved
src/components/new-safe/create/steps/StatusStep/StatusStepper.tsx
Outdated
Show resolved
Hide resolved
usame-algan
approved these changes
Aug 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #2370
How this PR fixes it
This updates the
@safe-global/safe-core-sdk
to3.3.5
as per requested which fixes Safe address prediction on ZK chains.How to test it
Create a Safe on a ZK chain and observe the correct Safe address in the creation stepper/navigation link after indexed.
Checklist