Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: send deviceType to GTM #2430

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Feat: send deviceType to GTM #2430

merged 1 commit into from
Aug 25, 2023

Conversation

katspaugh
Copy link
Member

@katspaugh katspaugh commented Aug 23, 2023

What it solves

Sending a device type manually would allow us to disable the "Granular location & device data" on GA.

How to test

  • Open the app on desktop – every GTM event should have deviceType: 'desktop'
  • Open the app on a tablet (or just resize the window to < 900px) – every GTM event should have deviceType: 'tablet'
  • Open the app on mobile – – every GTM event should have deviceType: 'mobile'

@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Branch preview

✅ Deploy successful!

https://device--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I've tested navigating with different viewport sizes and saw the values end up in GTM. We still need to add the mapping in GTM/GA once we go live with this.

@francovenica
Copy link
Contributor

Looks good

Tried in the different resolutions ( >900px, 900 - 600px, <600px ) navigating through the site, checking that the "deviceType" is logged with the GTM event, correctly having the value depending on the screen resolution.
image

@katspaugh katspaugh merged commit a9dc783 into dev Aug 25, 2023
7 checks passed
@katspaugh katspaugh deleted the device branch August 25, 2023 05:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants