Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TxFlow close button zindex #2431

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix: TxFlow close button zindex #2431

merged 1 commit into from
Aug 23, 2023

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Aug 23, 2023

What it solves

Resolves #2429

How this PR fixes it

Removes the z-index for the close button

How to test it

  1. Scroll down in the tx flow window
  2. Try to press elements that are at the top of the screen e.g. nonce form
  3. Observe that its possible to interact with them

Screenshots

Screenshot 2023-08-23 at 11 28 36

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Branch preview

✅ Deploy successful!

https://close_z_index--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@francovenica
Copy link
Contributor

Thanks, looks good.
I can click the nonce field and the X icon still works as intended.

@usame-algan usame-algan merged commit 61b3080 into dev Aug 23, 2023
7 checks passed
@usame-algan usame-algan deleted the close-z-index branch August 23, 2023 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tx flow] The X icon to close overlaps elements in the form
3 participants