feat: show Beamer NPS on tx success screen #2461
Conversation
Branch preview⏳ Deploying a preview site... |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
src/hooks/Beamer/useBeamerNps.ts
Outdated
| const lastShown = window.Beamer.getCookie(LS_KEY) | ||
|
|
||
| if (!lastShown) { | ||
| window.Beamer.forceShowNPS() |
There was a problem hiding this comment.
Can you link to Beamer docs about this fn? Why do we "force" it?
There was a problem hiding this comment.
Have spoken with Beamer regarding this, as well as asked some other questions. I'll make this a draft for now and include what I hear back.
There was a problem hiding this comment.
As per our discussion, I've added comments to address this.
src/hooks/Beamer/useBeamerNps.ts
Outdated
| // randomly showing on pages that we don't want it to | ||
| // Note: this is not documented but confirmed by Beamer support | ||
| if (!lastShown) { | ||
| window.Beamer.forceShowNPS() |
There was a problem hiding this comment.
You could also unsubscribe right after.
It checks whether it was shown, matching that of their API. I just refactored the code a little bit according to your suggestion above. |
|
The feature is fine. The popUp shows up for the first time when you propose a transaction and then it doesn't show up anymore. Note: A large number of users use a 1/x safes, so is likely that they only create and execute tx at the same time, so all those people will not see this beamer popup. |
|
Recheck this after the last commit. Made sure it still works only with the Beamer checkbox enabled in preferences LGTM |
What it solves
Resolves #2432
How this PR fixes it
Beamer's NPS is now shown on the transaction
PROPOSED.How to test it
Create a transaction, observing the NPS opening when the proposal succeeds.
Screenshots
Note: this is an old recording but the functionality should be the same, but on proposal.
Checklist