Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: help centre article link placeholder #2557

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

iamacook
Copy link
Member

What it solves

Adds help center link to the push notifications settings page.

How this PR fixes it

A new "Learn more about push notifications here" sentence has been added to the end of the description of push notifications in the per-Safe/global notifications settings.

How to test it

Open the per-Safe/global notifications settings and observe the new sentence/working link.

Screenshots

image

image

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Sep 27, 2023
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Branch preview

✅ Deploy successful!

https://push_notification_link--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Base automatically changed from release/1.19.0 to main September 28, 2023 16:17
@iamacook iamacook changed the base branch from main to dev September 29, 2023 11:33
@iamacook iamacook changed the title Draft: feat: help centre article link placeholder feat: help centre article link placeholder Sep 29, 2023
@iamacook iamacook marked this pull request as ready for review September 29, 2023 11:34
@francovenica
Copy link
Contributor

Looks good. The link is both, in a safe settgins and the global preferences.

It takes to https://help.safe.global/en/articles/99197-how-to-start-receiving-web-push-notifications-in-the-web-wallet

Note: at the moment of writing this comment, the article still doesn't exist.

@katspaugh katspaugh changed the base branch from dev to main October 2, 2023 06:39
@katspaugh katspaugh merged commit beac185 into main Oct 2, 2023
8 of 9 checks passed
@katspaugh katspaugh deleted the push-notification-link branch October 2, 2023 07:05
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants