Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: uncaught exception in ApprovalEditor #2674

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix: uncaught exception in ApprovalEditor #2674

merged 1 commit into from
Oct 23, 2023

Conversation

katspaugh
Copy link
Member

What it solves

ABI decoded was throwing in some rare cases.

Screenshot 2023-10-20 at 15 05 02

@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Branch preview

✅ Deploy successful!

https://exception--walletweb.review-wallet-web.5afe.dev

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.83% (-0.01% 🔻)
8963/11978
🔴 Branches 48.69% 1806/3709
🔴 Functions 56.96% 1322/2321
🟡 Lines
76.42% (-0.01% 🔻)
8100/10600
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / transactions.ts
60.18% (-0.73% 🔻)
31.03% 28.57%
64.29% (-0.98% 🔻)

Test suite run success

961 tests passing in 133 suites.

Report generated by 🧪jest coverage report action from c9a6b7a

Copy link
Member

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 🥁

@katspaugh
Copy link
Member Author

Yeah, literally :D

@katspaugh katspaugh merged commit 77f8862 into dev Oct 23, 2023
9 checks passed
@katspaugh katspaugh deleted the exception branch October 23, 2023 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants