Feat: Kiln widget #3962

compojoom · 2024-07-17T11:37:44Z

Other changes

Staking and Swaps share a lot of components, so we've extracted some of the Swaps components to generic components.
Method call and parameters for Swaps were moved to the Advanced details to be consistent with other tx types (see https://dinky.dog/?q=tx-details_f481530497111930).
All other tx types, where we previously weren't displaying method call and parameters at all, will have that block also in Advanced details.

github-actions · 2024-07-17T11:38:00Z

Branch preview

✅ Deploy successful!

Website:
https://feat_staking_kiln--walletweb.review.5afe.dev/home?safe=eth:0xA77DE01e157f9f57C7c4A326eeE9C4874D0598b6

Storybook:
https://feat_staking_kiln--walletweb.review.5afe.dev/storybook/

github-actions · 2024-07-17T11:39:09Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2024-07-17T11:41:33Z

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page	Size (compressed)
`global`	`953.35 KB` (🟡 +3.74 KB)

Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Page Added

The following page was added to the bundle from the code in this PR:

Page	Size (compressed)	First Load
`/stake`	`589 B`	953.92 KB

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load
`/apps`	`50.18 KB` (-2 B)	1003.53 KB
`/apps/custom`	`41.79 KB` (-2 B)	995.14 KB
`/apps/open`	`54.74 KB` (🟡 +1.16 KB)	1008.09 KB
`/home`	`60.25 KB` (🟢 -73 B)	1013.6 KB
`/settings/safe-apps`	`25.55 KB` (-2 B)	978.9 KB
`/settings/setup`	`35.95 KB` (-3 B)	989.3 KB
`/swap`	`723 B` (🟡 +77 B)	954.05 KB
`/transactions`	`73.47 KB` (🟢 -374 B)	1 MB
`/transactions/history`	`73.43 KB` (🟢 -376 B)	1 MB
`/transactions/messages`	`39.12 KB` (🟢 -79 B)	992.47 KB
`/transactions/msg`	`29.5 KB` (🟢 -79 B)	982.85 KB
`/transactions/queue`	`31.22 KB` (🟢 -79 B)	984.57 KB
`/transactions/tx`	`21.05 KB` (🟢 -79 B)	974.4 KB

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

github-actions · 2024-07-17T11:43:44Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	78.25% (-0.2% 🔻)	11937/15254
🔴	Branches	58.3% (-0.7% 🔻)	3053/5237
🟡	Functions	65.43% (-0.39% 🔻)	1887/2884
🟡	Lines	79.74% (-0.15% 🔻)	10774/13511

Show new covered files 🐣

St.^❔	File	Statements	Branches	Functions	Lines
🟢	`...` / index.tsx	75%	100%	0%	100%
🟢	`...` / index.tsx	60%	100%	0%	100%
🟢	`...` / index.tsx	85.71%	0%	0%	100%
🟢	`...` / Deposit.tsx	83.33%	0%	0%	90.91%
🟢	`...` / ConfirmationOrderHeader.tsx	75%	0%	0%	85.71%
🟡	`...` / index.tsx	71.43%	0%	0%	76.92%
🟢	`...` / index.tsx	77.78%	0%	0%	87.5%
🟡	`...` / index.tsx	55.56%	0%	0%	62.5%
🔴	`...` / index.tsx	45.45%	0%	0%	50%
🟢	`...` / Exit.tsx	75%	0%	0%	85.71%

Show files with reduced coverage 🔻

St.^❔	File	Statements	Branches	Functions	Lines
🟡	`...` / transaction-guards.ts	70.27% (-5.98% 🔻)	36.21% (-12.73% 🔻)	68.42% (-6.09% 🔻)	71.88% (-7.02% 🔻)
🟡	`...` / formatters.ts	74.14% (-3.22% 🔻)	57.14% (-4.4% 🔻)	76.92% (-6.41% 🔻)	74.42% (-2.5% 🔻)
🟡	`...` / extractTxInfo.ts	68.75% (-7.99% 🔻)	39.22% (-6.24% 🔻)	100%	68.09% (-8.11% 🔻)
🟢	src/utils/url.ts	82.35% (-2.83% 🔻)	100%	80% (+5% 🔼)	89.29% (-6.37% 🔻)
🟢	`...` / index.tsx	86.84% (+7.43% 🔼)	39.39% (-2.54% 🔻)	50%	86.11% (+7.99% 🔼)
🟢	`...` / useIsRecoverySupported.ts	100%	50% (-50% 🔻)	100%	100%
🟢	`...` / index.tsx	87.06% (-0.58% 🔻)	75.56% (+0.56% 🔼)	50%	86.42% (-0.64% 🔻)
🔴	`...` / index.tsx	56% (-0.52% 🔻)	0%	20%	59.09% (-0.91% 🔻)
🟡	`...` / index.tsx	71.15% (-0.54% 🔻)	11.43% (+0.32% 🔼)	66.67%	72% (-0.55% 🔻)
🟢	`...` / index.tsx	100%	50% (-50% 🔻)	100%	100%
🟡	`...` / index.tsx	66.67% (-2.08% 🔻)	0%	0%	70.97% (-2.37% 🔻)
🟢	`...` / index.tsx	75% (-13.89% 🔻)	100%	0%	100%
🟡	`...` / useTransactionType.tsx	62.22% (-5.22% 🔻)	37.78% (-1.76% 🔻)	100%	62.79% (-5.5% 🔻)
🟡	`...` / index.tsx	73.97% (-1.37% 🔻)	60.61% (+1.99% 🔼)	40%	73.91% (-1.45% 🔻)

Test suite run success

1484 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 5adb8ea

github-actions · 2024-07-30T14:44:26Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2024-08-06T14:48:37Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

…t-staking-kiln

github-actions · 2024-08-13T12:09:43Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

…t-staking-kiln

github-actions · 2024-08-21T12:52:52Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

github-actions · 2024-08-23T14:44:47Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

katspaugh · 2024-09-09T08:25:26Z

src/features/swap/components/SwapOrderConfirmationView/OrderFeeConfirmationView.tsx

+export const OrderFeeConfirmationView = ({
+  order,
+}: {
+  order: Pick<SwapOrderConfirmationView | TwapOrderConfirmationView, 'fullAppData'>


Replace with AnySwapConfirmationView?

compojoom · 2024-09-10T13:58:21Z

src/components/safe-apps/AppFrame/index.tsx

-          onDismiss={dismissQueueBar}
-          transactions={transactions}
-        />
+        {!isNativeEmbed && (


It's a bit unclear why a native Embed wouldn't have the transactionQueueBar. I remember talking to @schmanu and I think he likes the bar and even wanted to have it for the swap feature.

Maybe a more explicit name such as "hideTransactionBar" is more appropriate? But then I see above that we are also removing the page title... and also not emitting tracking events.

I think native swaps and native staking are both basically full screen Safe apps. So I do not see a reason to hide the queue bar if there are transactions in the queue.
Especially if some actions require multiple interactions, forcing users to switch context means that likely the widgets will load back into their original state so some context could be lost.

I'm not against keeping it. It's just not consistent with other pages. Why don't we show it on all pages except for the queue itself?

Anyway, I removed the check that hides the queue bar.

compojoom · 2024-09-10T14:30:52Z

src/components/tx/ConfirmationOrder/TokenInfoPair/index.tsx

+  }
+}
+
+const TokenInfoPair = ({ blocks, showArrow }: { blocks: [InfoBlock, InfoBlock]; showArrow?: boolean }) => {


That name is a small lie & you know it :)
Maybe a better name would be BlockInfoPair?

Maybe ConfirmationOrderHeader?

compojoom · 2024-09-10T14:35:08Z

src/components/tx/DecodedTx/index.tsx

  const chainId = useChainId()
-  const isMethodCallInAdvanced = !showMethodCall || isMultisend
+  const isMultisend = !!decodedData?.parameters?.[0]?.valueDecoded
+  const isMethodCallInAdvanced = !showMethodCall || (isMultisend && showMultisend)


The showMultisend here is confusing. Now the name is isMethodCallInAdvanced, but since showMultisend could be false this would also be false, despite the method call being in advanced. I'm more for havign showMultisend inside of the render.

Just to make sure we understand the same logic. We move the method name and parameters to Advanced details in two cases:

When showMethodCall is set to false in props

When it's a multi-send and showMultisend from props is true

How would you make this less confusing?

Let's leave it like this for now as @clovisdasilvaneto and I are refactoring this more comprehensively.

github-actions · 2024-09-11T07:24:46Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

liliya-soroka · 2024-09-11T12:05:15Z

@katspaugh , regression issue :
call .... on contract is missing on the swap tx details after refactoring

According to the design for staking it should not be hidden under the advanced parameters. Could we leave it , as it was previously and leave it according to the expected design - https://www.figma.com/design/ih2mM8bt8rNwbwV9EMmWF5/Staking?node-id=3166-8821&t=koQt4lxTOPWuHFVT-4

Edit by @katspaugh:

I've updated the description with a justification for this change + linked to a diagram. ✅

liliya-soroka · 2024-09-11T12:14:43Z

colour of the state is also changed to the different from the expected according tot he design :

Expected:

Edit by @katspaugh:

Fixed ✅

github-actions · 2024-09-11T13:19:01Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

.

github-actions · 2024-09-12T13:15:22Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

compojoom force-pushed the feat-staking-kiln branch from 3f1d212 to 18a7357 Compare July 30, 2024 14:46

compojoom added 2 commits July 30, 2024 16:47

feat: experiment with kiln widget

7779640

feat: add stake concent warning

d935b59

compojoom force-pushed the feat-staking-kiln branch from 18a7357 to d935b59 Compare July 30, 2024 14:47

fix: wrong widget url

f6b4970

compojoom changed the title ~~Test~~ Kiln widget Aug 6, 2024

compojoom force-pushed the feat-staking-kiln branch 2 times, most recently from b443464 to 5d548c5 Compare August 6, 2024 15:08

feat: add theme support for staking widget

0192052

compojoom force-pushed the feat-staking-kiln branch from 5d548c5 to 0192052 Compare August 6, 2024 15:12

compojoom and others added 2 commits August 7, 2024 09:35

fix: use https address

03b7c81

Merge branch 'dev' of github.com:safe-global/safe-wallet-web into fea…

28613c3

…t-staking-kiln

Merge branch 'dev' of github.com:safe-global/safe-wallet-web into fea…

4b52160

…t-staking-kiln

katspaugh force-pushed the feat-staking-kiln branch from 1860841 to 4b52160 Compare August 13, 2024 15:14

Merge branch 'dev' of github.com:safe-global/safe-wallet-web into fea…

d46e1ad

…t-staking-kiln

katspaugh added 5 commits August 22, 2024 10:38

Decoding + ifram tweaks

098e516

OrderConfirmationView

30b3c9a

Switch the widget to testnet

d597ecf

Format values

2389668

Merge with dev

357a8c1

katspaugh force-pushed the feat-staking-kiln branch from 67c9321 to 5f89012 Compare August 23, 2024 14:57

Capitalize status labels

9b864c6

katspaugh force-pushed the feat-staking-kiln branch from 1f12a94 to 9b864c6 Compare August 30, 2024 14:27

katspaugh added 4 commits August 30, 2024 17:39

Fix unit test

4b8b026

Reuse widget disclaimer component

7b6ab3e

Adjust type

b5ba326

Unify status chips

831cfa0

katspaugh reviewed Sep 9, 2024

View reviewed changes

katspaugh marked this pull request as ready for review September 10, 2024 12:43

compojoom commented Sep 10, 2024

View reviewed changes

katspaugh added 2 commits September 11, 2024 09:21

Merge with dev

b86a675

Keep queue bar on the stake page

b18656b

TokenInfoPair -> ConfirmationOrderHeader

dda4823

katspaugh approved these changes Sep 11, 2024

View reviewed changes

Fix status chip style

a7ff10a

katspaugh and others added 2 commits September 12, 2024 11:09

Merge branch 'dev' into feat-staking-kiln

32eb614

Rm sidebar tooltip

72fbd8f

katspaugh force-pushed the feat-staking-kiln branch from 798e334 to 72fbd8f Compare September 12, 2024 09:47

compojoom and others added 3 commits September 12, 2024 12:06

feat: add decoding for withdraw request

eaa4728

.

Merge with dev

b6e2e65

fix: failing tests

5adb8ea

katspaugh merged commit 2fcd8fc into dev Sep 12, 2024
16 checks passed

katspaugh deleted the feat-staking-kiln branch September 12, 2024 13:50

github-actions bot locked and limited conversation to collaborators Sep 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Kiln widget #3962

Feat: Kiln widget #3962

compojoom commented Jul 17, 2024 •

edited by katspaugh

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Jul 30, 2024 •

edited

Loading

github-actions bot commented Aug 6, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 21, 2024 •

edited

Loading

github-actions bot commented Aug 23, 2024 •

edited

Loading

katspaugh Sep 9, 2024

compojoom Sep 10, 2024

schmanu Sep 10, 2024

katspaugh Sep 10, 2024 •

edited

Loading

katspaugh Sep 11, 2024

compojoom Sep 10, 2024

katspaugh Sep 10, 2024

compojoom Sep 10, 2024

katspaugh Sep 10, 2024

katspaugh Sep 11, 2024

github-actions bot commented Sep 11, 2024 •

edited

Loading

liliya-soroka commented Sep 11, 2024 •

edited by katspaugh

Loading

liliya-soroka commented Sep 11, 2024 •

edited by katspaugh

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024

Feat: Kiln widget #3962

Feat: Kiln widget #3962

Conversation

compojoom commented Jul 17, 2024 • edited by katspaugh Loading

Other changes

github-actions bot commented Jul 17, 2024 • edited Loading

Branch preview

github-actions bot commented Jul 17, 2024 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Jul 17, 2024 • edited Loading

📦 Next.js Bundle Analysis for safe-wallet-web

⚠️ Global Bundle Size Increased

New Page Added

Thirteen Pages Changed Size

github-actions bot commented Jul 17, 2024 • edited Loading

Coverage report

Test suite run success

github-actions bot commented Jul 30, 2024 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Aug 6, 2024 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Aug 13, 2024 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Aug 21, 2024 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Aug 23, 2024 • edited Loading

ESLint Summary View Full Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katspaugh Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 11, 2024 • edited Loading

ESLint Summary View Full Report

liliya-soroka commented Sep 11, 2024 • edited by katspaugh Loading

liliya-soroka commented Sep 11, 2024 • edited by katspaugh Loading

github-actions bot commented Sep 11, 2024 • edited Loading

ESLint Summary View Full Report

github-actions bot commented Sep 12, 2024

ESLint Summary View Full Report

compojoom commented Jul 17, 2024 •

edited by katspaugh

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Jul 17, 2024 •

edited

Loading

github-actions bot commented Jul 30, 2024 •

edited

Loading

github-actions bot commented Aug 6, 2024 •

edited

Loading

github-actions bot commented Aug 13, 2024 •

edited

Loading

github-actions bot commented Aug 21, 2024 •

edited

Loading

github-actions bot commented Aug 23, 2024 •

edited

Loading

katspaugh Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

liliya-soroka commented Sep 11, 2024 •

edited by katspaugh

Loading

liliya-soroka commented Sep 11, 2024 •

edited by katspaugh

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading