-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: replace deprecated timezone_offset parameter with timezone #4159
Conversation
…eprecated timezone_offset
All contributors have signed the CLA ✍️ ✅ |
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Currently, there are some errors present due to the SDK version not being updated. Please ensure to update the SDK version accordingly. |
I have read the CLA Document and I hereby sign the CLA |
Coverage report
Show new covered files 🐣
Test suite run success1483 tests passing in 203 suites. Report generated by 🧪jest coverage report action from cd8cbbf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can now install @safe-global/safe-gateway-typescript-sdk@3.22.4-beta.1
and commit that as well so that we can test this PR.
@katspaugh Done ✅ |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
949.6 KB (🟡 +2 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
package.json
Outdated
@@ -158,5 +158,6 @@ | |||
"budgetPercentIncreaseRed": 20, | |||
"minimumChangeThreshold": 0, | |||
"showDetails": true | |||
} | |||
}, | |||
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Tested, the timezone parameter is added and the date labels are correct. ✅ |
Removes deprecated timezone_offset, Adds
timezone
as a replacement.What it solves
Resolves
safe-global/safe-client-gateway#1024
How this PR fixes it
A new query parameter, timezone, has been introduced. This parameter accepts only valid timezone strings (e.g., Europe/Berlin) and supersedes the deprecated timezone_offset, which previously accepted a numeric timezone difference.
How to test it
For more info please visit Add support for client timezone information safe-client-gateway#1024
Screenshots
Checklist