-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: staking claim [SW-160] #4167
Conversation
Branch preview✅ Deploy successful! Storybook: |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
953.62 KB (🟡 +279 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1484 tests passing in 203 suites. Report generated by 🧪jest coverage report action from 5d8367f |
|
||
export const getStakeTitle = (txs: BaseTransaction[] | undefined) => { | ||
const hashToLabel = { | ||
[WITHDRAW_SIGHASH]: 'Withdraw request', | ||
[CLAIM_SIGHASH]: 'Claim', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can’t these titles be deduced from the txInfo/txConfirmation type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the call - we currently do this because the app title is a component that is rendered before the modal content and as such it doesn't have access to the txInfo. This would need a refactoring (since you guys are working on the txflow #4157 you can consider it there)
Tested, it works correctly ✅ I'm not convinced it's a good idea to say "Receive" in one place but "Amount" in another for the exact same thing (rewards mount). @TanyaEfremova shall we unify the phrasing maybe? |
@compojoom also I would make the gap between these two blocks a tiny bit bigger (notice that the space above Receive is bigger than below): |
@katspaugh You're right, it's not intended to say 'Amount'. Both screens (transaction summary and transaction confirmation) are now aligned in Figma. |
3646254
to
6eb82ac
Compare
9c2da6c
to
5d8367f
Compare
What it solves
Ads decoding views for stake claim txs
Resolves #
How this PR fixes it
How to test it
Screenshots
Checklist