Bump @safe-global/api-kit and @safe-global/protocol-kit versions #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why all the tests failed Maybe I don't have enough permissions |
|
Sorry for tagging, I just hope that this PR can be resolved even though almost all CI jobs have failed😅 Is there a chance for this to be merged? I believe I haven't introduced any breaking changes, as I only bumped a patch version. I hope it can be merged and published, if possible, of course |
|
No, it's good. I'll merge it later. I tested it locally. Our CI can't run tests from external contributors. That's why it fails. |
|
Thanks! |
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Safe Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
This PR bumps the version of the
@safe-global/api-kitand@safe-global/protocol-kitpackages.This will allow the use of the Safe frontend on the recently added chains (like Q, Snaxchain, etc.)
Currently, even during local installation of https://github.com/safe-global/safe-wallet-web, it forces the ^4.1.0 version of the
@safe-global/protocol-kitpackage, ignoring the ^ symbolThis PR related to the: safe-global/safe-core-sdk#983 and safe-global/safe-core-sdk#987
Fixes: #4292