fix: Handle special characters for prefix in address input #4287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Noticed that the
AddressInput
unit test randomly fails sometimes. This happens when faker generates a shortName with a hyphen or other special characters in it so I adjusted our cleanup function to handle such characters.How this PR fixes it
cleanInputValue
to not only handlea-z0-9
characters in the prefix but any character that is not a:
cleanInputValue
How to test it
test-prefix:<some address>
into the recipient fieldeth:<some address>
Screenshots
On prod when typing
test-hyphen:<some address>
With the change when typing
test-hyphen:<some address>
Checklist