feat: show message and domain hash #4394
Conversation
Branch preview✅ Deploy successful! Storybook: |
| <TxDataRow datatestid="tx-safe-hash" title="safeTxHash:"> | ||
| {generateDataRowValue(safeTxHash, 'hash')} | ||
| </TxDataRow> | ||
| <TxDataRow datatestid="tx-safe-hash" title="Domain hash:"> | ||
| {generateDataRowValue(domainHash, 'hash')} | ||
| </TxDataRow> | ||
| {messageHash && ( | ||
| <TxDataRow datatestid="tx-safe-hash" title="Message hash:"> | ||
| {generateDataRowValue(messageHash, 'hash')} | ||
| </TxDataRow> |
There was a problem hiding this comment.
We should probably not use the same data-testid for all three rows. Could cause issues in the future with e2e tests.
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
993.94 KB (🟡 +396 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Coverage report
Show new covered files 🐣
Test suite run success1573 tests passing in 208 suites. Report generated by 🧪jest coverage report action from ae01330 |
What it solves
Resolves #4391
How this PR fixes it
Shows the internal message and domain hashes next to the safeTxHash.
How to test it
Screenshots
Checklist