Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide suspicious transactions by default #4425

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Conversation

iamacook
Copy link
Member

What it solves

Hiding suspicious transactions by default

How this PR fixes it

The default preference to hide suspicious transactions is now set to true.

How to test it

Ensuring no preferences are set, observe the "Hide suspicious" switch to be on by default in the transaction history.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Oct 25, 2024
@iamacook iamacook requested a review from schmanu October 25, 2024 12:48
Copy link

Copy link

github-actions bot commented Oct 25, 2024

Copy link

github-actions bot commented Oct 25, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1009.73 KB (🟡 +69 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@iamacook iamacook changed the title Hide suspicious transactions by default fix: hide suspicious transactions by default Oct 25, 2024
Copy link

github-actions bot commented Oct 25, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.71% (-0.01% 🔻)
13529/18355
🔴 Branches
51.47% (-0.03% 🔻)
3290/6392
🔴 Functions 57.26% 1969/3439
🟡 Lines
75.41% (-0.01% 🔻)
12302/16314
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / useTxPendingStatuses.ts
83.64% (-0.91% 🔻)
68.33% (-1.67% 🔻)
75%
92.63% (-1.05% 🔻)
🟢
... / useTxHistory.ts
96.67%
61.11% (-5.56% 🔻)
100% 96.43%

Test suite run success

1573 tests passing in 208 suites.

Report generated by 🧪jest coverage report action from d6f1f93

@iamacook iamacook merged commit 1b1f128 into dev Oct 25, 2024
15 checks passed
@iamacook iamacook deleted the hide-suspicious-txs branch October 25, 2024 15:51
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants