Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ SW-467 ] fix(threshold-info): Display right info in the change threshold confirmation screen #4465

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

clovisdasilvaneto
Copy link
Contributor

What it solves

Confirm threshold screen is showing 0 of (n) when user comes from the transaction list.

How this PR fixes it

Before we were grabbing the threshold information from the changeThreshold screen flow, but this information is not available when user comes from the transactions list (for eg, in order to confirm a change threshold transaction)

How to test it

  • Change the threshold of your account
  • sign but do not execute it
  • go to the transaction list and try to confirm or execute it from there.
  • The amount of required signers now should be working as expected instead of showing "0 out (n)"

Screenshots

Screenshot 2024-11-04 at 12 21 11

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Nov 4, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

github-actions bot commented Nov 4, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
74.09% (+0.01% 🔼)
13904/18767
🔴 Branches
52.72% (-0% 🔻)
3427/6500
🔴 Functions 57.92% 2029/3503
🟡 Lines
75.76% (+0% 🔼)
12633/16675
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / index.tsx
100%
40% (-60% 🔻)
100% 100%

Test suite run success

1593 tests passing in 215 suites.

Report generated by 🧪jest coverage report action from 98af511

@liliya-soroka liliya-soroka changed the title fix(threshold-info): Display right info in the change threshold confirmation screen [ SW-467 ] fix(threshold-info): Display right info in the change threshold confirmation screen Nov 7, 2024
Copy link

@francovenica
Copy link
Contributor

Looks good to me.

A before/after screenshots:
image
image

@clovisdasilvaneto clovisdasilvaneto merged commit 35decc8 into dev Nov 15, 2024
15 checks passed
@clovisdasilvaneto clovisdasilvaneto deleted the fix/threshold-in-confirmation-view branch November 15, 2024 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants