Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update proposers help article link [SW-301] #4506

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Nov 7, 2024

What it solves

Resolves SW-301

How this PR fixes it

  • Updates the help article link for proposers

How to test it

  1. Go to settings
  2. Press "Learn more" under Proposers section
  3. Observe the new link opening

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

Update the help article

Copy link

github-actions bot commented Nov 7, 2024

Copy link

github-actions bot commented Nov 7, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 1014.08 KB (🟡 +58 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/settings/setup 47.01 KB (🟢 -9 B) 1.04 MB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Nov 7, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 74.25% 14062/18939
🔴 Branches 52.57% 3476/6612
🔴 Functions 58.04% 2053/3537
🟡 Lines 75.88% 12774/16835

Test suite run success

1619 tests passing in 217 suites.

Report generated by 🧪jest coverage report action from ec15502

Copy link
Contributor

@compojoom compojoom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I also tested that the link leads to the correct page. Works!

@usame-algan usame-algan merged commit b9b0567 into dev Nov 8, 2024
15 checks passed
@usame-algan usame-algan deleted the proposers-help-article branch November 8, 2024 09:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants