Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugfix to handle cases where the package name doesn't resolve properly #305

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

insaaniManav
Copy link
Contributor

Fixes #300

Copy link

github-actions bot commented Jan 8, 2025

vet Summary Report

This report is generated by vet

Policy Checks

  • ✅ Vulnerability
  • ✅ Malware
  • ✅ License
  • ✅ Popularity
  • ✅ Maintenance
  • ✅ Security Posture
  • ✅ Threats
Changed Packages

Changed Packages

  • ✅ [Go] stdlib@1.23

@insaaniManav insaaniManav force-pushed the fix/lockfile-poisoning branch from 3291a42 to 9730cd6 Compare January 8, 2025 08:33
@abhisek abhisek self-requested a review January 9, 2025 09:18
pkg/analyzer/lfp_npm.go Outdated Show resolved Hide resolved
pkg/analyzer/lfp_npm.go Outdated Show resolved Hide resolved
@abhisek
Copy link
Member

abhisek commented Jan 10, 2025

@insaaniManav Can you rebase with main please. Want to ensure CI is passing with latest base.

@insaaniManav insaaniManav force-pushed the fix/lockfile-poisoning branch from b6fff4e to 52212f8 Compare January 10, 2025 06:42
pkg/analyzer/lfp_npm.go Outdated Show resolved Hide resolved
@abhisek
Copy link
Member

abhisek commented Jan 13, 2025

@insaaniManav The CI was failing due to a flaky test that involves GH API. I re-ran the CI failed tests and it seems to be green

@insaaniManav
Copy link
Contributor Author

Cool can you review the code ? This is done from my end

@abhisek abhisek merged commit 01396c1 into main Jan 14, 2025
9 checks passed
@abhisek abhisek deleted the fix/lockfile-poisoning branch January 14, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lockfile Poisoning Analyser Bug in Path Handling
2 participants