Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/karate setup #56

Merged
merged 11 commits into from
Dec 12, 2024
Merged

Conversation

olisaagbafor
Copy link
Contributor

@olisaagbafor olisaagbafor commented Dec 12, 2024

Karate Test Environment Setup

This PR replaces #42

Changes

  • Add Docker Compose setup for test environment
  • Configure Karate test framework
  • Set up test result reporting to tests/results
  • Add README with test execution instructions

Reference

This PR continues the work from #42 , which is being closed in favor of this PR to align with project commit guidelines.

Previous discussion: #42

📂 Related Issue

This pull request will close #29 - Implement automated API testing infrastructure


🎉 Thank you for reviewing this PR!

- Add Cucumber reporting dependencies
- Configure Maven Surefire plugin for report generation
- Add TestRunner class with report generation logic
- Update Docker configuration for report persistence
- Add .gitignore for report directories
- Add Docker Compose setup for test environment
- Configure Karate test framework
- Set up test result reporting to tests/results
- Add README with test execution instructions

This commit sets up the initial testing infrastructure using Karate
framework and Docker Compose, enabling automated API testing against
a containerized Hasura GraphQL engine.
@zleypner
Copy link
Contributor

Hello @olisaagbafor , Thank you for all the updates and your quality work. I will test one more time to make sure everything is running and then I will proceed to merge.

Copy link
Contributor

@zleypner zleypner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rdy to merge

@zleypner
Copy link
Contributor

Thanks @olisaagbafor for this outstanding work! The implementation of the Karate testing framework is extremely well-structured and thorough. I particularly appreciate:

Your responsiveness to feedback and willingness to iterate on improvements
The clear documentation and testing instructions you've added to the README
Your professional approach to addressing all review comments and technical issues

Your attention to detail and commitment to quality really shows through in this PR. This testing infrastructure will be invaluable for maintaining code quality as we scale. Great job on delivering such a robust solution! 🎯 👏

I will proceed to merge. This issue closes #29

@zleypner zleypner merged commit 679fe14 into safetrustcr:main Dec 12, 2024
@olisaagbafor
Copy link
Contributor Author

Thanks @zleypner, thanks to the SafeTrust team, thanks also for the opportunity to contribute to this amazing project, thanks greatly for the reward, I so much appreciate and I look forward to working more with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Karate Testing Framework for GraphQL API - Users Module
2 participants