Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upgrade command #6

Merged
merged 5 commits into from
Mar 16, 2018
Merged

Add upgrade command #6

merged 5 commits into from
Mar 16, 2018

Conversation

aknysh
Copy link
Contributor

@aknysh aknysh commented Mar 16, 2018 •
edited
Loading

what

  • Add upgrade command

why

  • To upgrade a release to a new version of the chart from a GitHub repo

test

Install the Helm plugin

helm plugin install --version feature-add-charts-upgrade https://github.com/sagansystems/helm-github.git

Install Helm chart from GitHub

helm github install --repo git@github.com:kubernetes/charts.git --path stable/external-dns

Cloning into '/Users/andriyknysh/.helm/plugins/helm-github/repos/charts'...
remote: Counting objects: 22425, done.
remote: Total 22425 (delta 0), reused 0 (delta 0), pack-reused 22425
Receiving objects: 100% (22425/22425), 4.47 MiB | 7.87 MiB/s, done.
Resolving deltas: 100% (15421/15421), done.
Already on 'master'
Your branch is up-to-date with 'origin/master'.
/Users/andriyknysh/Documents/Projects/CloudPosse/Programs/Projects/Gladly/helm-github
Installing the Helm chart from the GitHub repo
NAME:   nuanced-jellyfish
LAST DEPLOYED: Fri Mar 16 00:02:26 2018
NAMESPACE: default
STATUS: DEPLOYED

RESOURCES:
==> v1/Service
NAME                            TYPE       CLUSTER-IP     EXTERNAL-IP  PORT(S)   AGE
nuanced-jellyfish-external-dns  ClusterIP  10.104.18.208  <none>       7979/TCP  0s

==> v1beta1/Deployment
NAME                            DESIRED  CURRENT  UP-TO-DATE  AVAILABLE  AGE
nuanced-jellyfish-external-dns  1        1        1           0          0s

==> v1/Pod(related)
NAME                                             READY  STATUS             RESTARTS  AGE
nuanced-jellyfish-external-dns-759b77d5fc-zkqhb  0/1    ContainerCreating  0         0s

Upgrade Helm chart from GitHub

helm github upgrade nuanced-jellyfish --repo git@github.com:kubernetes/charts.git --path stable/external-dns

Already on 'master'
Your branch is up-to-date with 'origin/master'.
Already up-to-date.
Already on 'master'
Your branch is up-to-date with 'origin/master'.
/Users/andriyknysh/Documents/Projects/CloudPosse/Programs/Projects/Gladly/helm-github
Upgrading nuanced-jellyfish release to a new version of the chart from the GitHub repo
Release "nuanced-jellyfish" has been upgraded. Happy Helming!
LAST DEPLOYED: Fri Mar 16 00:04:18 2018
NAMESPACE: default
STATUS: DEPLOYED

RESOURCES:
==> v1/Service
NAME                            TYPE       CLUSTER-IP     EXTERNAL-IP  PORT(S)   AGE
nuanced-jellyfish-external-dns  ClusterIP  10.104.18.208  <none>       7979/TCP  1m

==> v1beta1/Deployment
NAME                            DESIRED  CURRENT  UP-TO-DATE  AVAILABLE  AGE
nuanced-jellyfish-external-dns  1        1        1           1          1m

==> v1/Pod(related)
NAME                                             READY  STATUS   RESTARTS  AGE
nuanced-jellyfish-external-dns-759b77d5fc-zkqhb  1/1    Running  0         1m

@aknysh aknysh self-assigned this Mar 16, 2018
@aknysh aknysh requested a review from osterman March 16, 2018 03:42
@osterman osterman requested a review from darend March 16, 2018 03:44
osterman
osterman reviewed Mar 16, 2018
View reviewed changes
github-install.sh Outdated
fi

# Update plugin
# Update this plugin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Update this helm plugin"

osterman
osterman reviewed Mar 16, 2018
View reviewed changes
plugin.yaml Outdated
@@ -1,5 +1,5 @@
name: "github"
version: "0.1.0"
version: "0.1.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this a major release since we're adding a new action.

osterman
osterman reviewed Mar 16, 2018
View reviewed changes
plugin.yaml Outdated
@@ -1,5 +1,5 @@
name: "github"
version: "0.1.0"
version: "0.1.1"
usage: "Install helm charts from github repos"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Install Helm charts from GitHub repos"

osterman
osterman reviewed Mar 16, 2018
View reviewed changes
plugin.yaml Outdated
@@ -1,5 +1,5 @@
name: "github"
version: "0.1.0"
version: "0.1.1"
usage: "Install helm charts from github repos"
description: |-
This plugin installs raw Helm charts from Github.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename this from github-install.sh to something more generic since now it also does upgrades. Perhaps call it just github.sh or github-plugin.sh

osterman
osterman reviewed Mar 16, 2018
View reviewed changes
LICENSE Outdated
@@ -186,7 +186,7 @@
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [2017] [Gladly Software, Inc.]
Copyright [2017-2018] [Gladly Software, Inc.]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove brackets.

@aknysh aknysh requested a review from osterman March 16, 2018 04:08
osterman
osterman approved these changes Mar 16, 2018
View reviewed changes
Copy link
Contributor

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove brackets in Copyright.
  • Normalize Github to GitHub
  • Wait for @darend to give final approval

darend
darend approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member

@darend darend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@darend darend merged commit 945aa21 into master Mar 16, 2018
@darend darend deleted the feature-add-charts-upgrade branch March 16, 2018 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darend darend darend approved these changes

@osterman osterman osterman approved these changes

Assignees

@aknysh aknysh

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aknysh @osterman @darend