refactor feature tests

sagautam5 · Feb 10, 2021 · b6b4e8f · b6b4e8f
1 parent f0a3680
commit b6b4e8f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 13 deletions.
diff --git a/tests/Feature/DistrictMunicipalityFeatureTest.php b/tests/Feature/DistrictMunicipalityFeatureTest.php
@@ -29,7 +29,7 @@ public function __construct()
     /**
      * @throws \Sagautam5\LocalStateNepal\Exceptions\LoadingException
      */
-    public function testGetDistrictsWithMunicipalities()
+    public function test_getDistrictsWithMunicipalities()
     {
         $districtsWithMunicipalities = $this->district->getDistrictsWithMunicipalities();
 
@@ -40,8 +40,7 @@ public function testGetDistrictsWithMunicipalities()
                 $this->fail('Failed to get associated municipalities of district');
             }
         }
-
-        if ($correct)
-            $this->assertTrue(true);
+
+        $this->assertTrue($correct);
     }
 }
diff --git a/tests/Feature/MunicipalityCountByCategoryTest.php b/tests/Feature/MunicipalityCountByCategoryTest.php
@@ -28,7 +28,7 @@ public function __construct()
     /**
      * Test Municipalities Count for Each Category
      */
-    public function testMunicipalityCountByCategory()
+    public function test_municipalityCountByCategory()
     {
         $categoryIdSet = range(1,4);
         $categoryCountSet = [6,11,276,460];
@@ -43,7 +43,6 @@ public function testMunicipalityCountByCategory()
             }
         }
 
-        if($correct)
-            $this->assertTrue(true);
+        $this->assertTrue($correct);
     }
 }
diff --git a/tests/Feature/ProvinceDistrictFeatureTest.php b/tests/Feature/ProvinceDistrictFeatureTest.php
@@ -33,7 +33,7 @@ public function __construct()
      *
      * @throws \Sagautam5\LocalStateNepal\Exceptions\LoadingException
      */
-    public function testGetProvincesWithDistricts()
+    public function test_getProvincesWithDistricts()
     {
         $provinceWithDistricts = $this->province->getProvincesWithDistricts();
 
@@ -45,16 +45,15 @@ public function testGetProvincesWithDistricts()
             }
         }
 
-        if ($correct)
-            $this->assertTrue(true);
+        $this->assertTrue($correct);
     }
 
     /**
      * Check if Districts And Their Municipalities Are Correctly Loaded With  Provinces
      *
      * @throws \Sagautam5\LocalStateNepal\Exceptions\LoadingException
      */
-    public function testGetProvincesWithDistrictsWithMunicipalities()
+    public function test_getProvincesWithDistrictsWithMunicipalities()
     {
         $provinceWithDistrictWithMunicipalities = $this->province->getProvincesWithDistrictsWithMunicipalities();
 
@@ -73,7 +72,6 @@ public function testGetProvincesWithDistrictsWithMunicipalities()
             }
         }
 
-        if($correct)
-            $this->assertTrue(true);
+        $this->assertTrue($correct);
     }
 }