Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status checker #5

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Status checker #5

wants to merge 4 commits into from

Conversation

luckychess
Copy link
Contributor

@luckychess luckychess commented Oct 15, 2024

A checker which queries all external endpoints for liveness for both testnet and mainnet.

var (
// SSC endpoints
grpcMainnet = "ssc-grpc.sagarpc.io:9090"
grpcTestnet = "testnet2-grpc.sagarpc.io:9090"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luckychess why do you want to hard-code these endpoints? Can't they be read from the environment or some other config that does not need to be compiled and deployed each time an endpoint is added/updated/removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashishchandr70 Hm, it was planned to be just a simple standalone service but this comment makes sense. I can add environment values for all the endpoints and set them in case they are not set externally, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashishchandr70 actually after some thinking I'm not sure, if we are going to use this tool in a long term. We'll probably migrate all the SSC VMs into GCP under k8s if even need them at all. So I suggest to keep this tool as simple as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants