-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status checker #5
base: main
Are you sure you want to change the base?
Conversation
var ( | ||
// SSC endpoints | ||
grpcMainnet = "ssc-grpc.sagarpc.io:9090" | ||
grpcTestnet = "testnet2-grpc.sagarpc.io:9090" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@luckychess why do you want to hard-code these endpoints? Can't they be read from the environment or some other config that does not need to be compiled and deployed each time an endpoint is added/updated/removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashishchandr70 Hm, it was planned to be just a simple standalone service but this comment makes sense. I can add environment values for all the endpoints and set them in case they are not set externally, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashishchandr70 actually after some thinking I'm not sure, if we are going to use this tool in a long term. We'll probably migrate all the SSC VMs into GCP under k8s if even need them at all. So I suggest to keep this tool as simple as possible.
A checker which queries all external endpoints for liveness for both testnet and mainnet.