Make default VersionNegotiation more conservative #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Upgrade` header that can be used for insecure upgrade from HTTP/1.x to HTTP/2 is not handled properly by many in-production HTTP servers and can result in an error when the request would otherwise succeed without the `Upgrade` header. Since there's not really any way for us to know if an error response was caused by our `Upgrade` header or not (and what the server state is for non-idempotent methods), `VersionNegotiation::latest_compatible` will no longer send this header, and instead rely exclusively on the server to explicitly _declare_ higher HTTP versions that it supports, either via ALPN or something else. Fixes #159.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Upgradeheader that can be used for insecure upgrade from HTTP/1.x to HTTP/2 is not handled properly by many in-production HTTP servers and can result in an error when the request would otherwise succeed without theUpgradeheader.Since there's not really any way for us to know if an error response was caused by our
Upgradeheader or not (and what the server state is for non-idempotent methods),VersionNegotiation::latest_compatiblewill no longer send this header, and instead rely exclusively on the server to explicitly declare higher HTTP versions that it supports, either via ALPN or something else.Fixes #159.