Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade curl-sys to fix static linking issues with older versions of macOS #169

Merged
merged 1 commit into from
Feb 19, 2020

Conversation

sagebind
Copy link
Owner

Fixes #68.

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #169 into master will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   48.93%   48.29%   -0.65%     
==========================================
  Files          20       20              
  Lines        1882     1876       -6     
  Branches      422      419       -3     
==========================================
- Hits          921      906      -15     
- Misses        675      678       +3     
- Partials      286      292       +6
Impacted Files Coverage Δ
src/auth.rs 41.09% <0%> (-13.7%) ⬇️
src/config/ssl.rs 22.85% <0%> (-8.58%) ⬇️
src/config/mod.rs 48.64% <0%> (-0.68%) ⬇️
src/cookies/psl/mod.rs 70.58% <0%> (-0.57%) ⬇️
src/handler.rs 59.72% <0%> (-0.46%) ⬇️
src/parse.rs 60.52% <0%> (ø) ⬆️
src/cookies/mod.rs 58.37% <0%> (+0.27%) ⬆️
src/client.rs 56.68% <0%> (+0.35%) ⬆️
src/agent.rs 44.39% <0%> (+0.39%) ⬆️
src/lib.rs 38.73% <0%> (+1.23%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c16160b...ed190b3. Read the comment docs.

@sagebind sagebind merged commit 5d59ce9 into master Feb 19, 2020
@sagebind sagebind deleted the 68-static-macos branch February 19, 2020 02:57
@sagebind sagebind added the bug Something is borken label Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation fails to link static libcurl on macOS <= 10.13
1 participant