Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Public Suffix List to c1d5b3c #184

Merged
merged 1 commit into from
May 7, 2020

Conversation

sagebind
Copy link
Owner

@sagebind sagebind commented May 7, 2020

Update Public Suffix List from 17ca522 to c1d5b3c.

This pull request was generated automatically. If you close this pull request, I won't bother you again until the next automatically scheduled update.

@sagebind sagebind added the dependencies Pull requests that update a dependency file label May 7, 2020
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #184 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   67.97%   67.97%           
=======================================
  Files          33       33           
  Lines        1808     1808           
=======================================
  Hits         1229     1229           
  Misses        579      579           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f92a04...50b04ad. Read the comment docs.

@sagebind sagebind merged commit 9254dcf into master May 7, 2020
@sagebind sagebind deleted the public-suffix-list/patch-1f92a04 branch May 7, 2020 01:38
zwilias pushed a commit to zwilias/isahc that referenced this pull request May 22, 2020
* Might fix sagebind#184

Signed-off-by: Ankur Srivastava <best.ankur@gmail.com>

* handle review

Signed-off-by: Ankur Srivastava <best.ankur@gmail.com>

* more test cases

Signed-off-by: Ankur Srivastava <best.ankur@gmail.com>

* trying to match with Any in tests

Signed-off-by: Ankur Srivastava <best.ankur@gmail.com>

* use keys to iterate over HeaderMap

Signed-off-by: Ankur Srivastava <best.ankur@gmail.com>

* removed DefaultHeaderMap implementation, not using .set_opt anymore

Signed-off-by: Ankur Srivastava <best.ankur@gmail.com>

* format

Signed-off-by: Ankur Srivastava <best.ankur@gmail.com>

* review comments:
- Keep the error as enum http::Error
- Commented out the failing tests until it gets fixed upstream in mockito

Signed-off-by: Ankur Srivastava <best.ankur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant