Replace default_headers_mut with default_headers #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thinking about future compatibility, we might want to leverage interceptors as an implementation detail for how default headers are set. To avoid locking us in the current implementation, do not expose the default `HeaderMap` as a direct reference. Instead, for users who want to set headers in bulk, provide `default_headers` which takes an iterator of key-value pairs and replaces all existing headers. That allows users to do the same kind of things without relying on a mutable `HeaderMap` being exposed.
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
==========================================
+ Coverage 67.97% 69.65% +1.68%
==========================================
Files 33 33
Lines 1808 1849 +41
==========================================
+ Hits 1229 1288 +59
+ Misses 579 561 -18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thinking about future compatibility, we might want to leverage interceptors someday as an implementation detail for how default headers are set. To avoid locking us in the current implementation, do not expose the default
HeaderMapas a direct reference. Instead, for users who want to set headers in bulk, providedefault_headerswhich takes an iterator of key-value pairs and replaces all existing headers. That allows users to do the same kind of things without relying on a mutableHeaderMapbeing exposed.Also tweak some docs.