Fix HEAD requests with a body on libcurl 7.70+ #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libcurl 7.70.0 introduced a breaking change that caused the order in which `CURLOPT_NOBODY` and `CURLOPT_UPLOAD` are set to matter. Previously we were setting `CURLOPT_UPLOAD` first and then `CURLOPT_NOBODY` when the user wishes to make a HEAD request with a request body. In libcurl 7.70+, `CURLOPT_NOBODY` implicitly changes the internal request type back to a normal HEAD request with no body, undoing the previous `CURLOPT_UPLOAD` call. Change the order of operations such that the response body is still ignored, but the internal request type is still PUT. See curl/curl@9c845be#diff-72ee0eef31d053c9e6d4fb22e81d2407
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
==========================================
- Coverage 69.63% 69.52% -0.11%
==========================================
Files 33 33
Lines 1867 1867
==========================================
- Hits 1300 1298 -2
- Misses 567 569 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libcurl 7.71.0 introduced a breaking change that caused the order in which
CURLOPT_NOBODYandCURLOPT_UPLOADare set to matter. Previously we were settingCURLOPT_UPLOADfirst and thenCURLOPT_NOBODYwhen the user wishes to make a HEAD request with a request body.Change the order of operations such that the response body is still ignored, but the internal request type is still PUT.
Fixes #214.