Don't combine nobody with upload #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on feedback from Stenberg himself, it doesn't really make much sense to set both `nobody` _and_ `upload` on the same request in order to fulfill weird HEAD requests with a request body. Change (and simplify) to use `nobody` for normal HEAD requests, and `upload` + `customrequest` otherwise.
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
- Coverage 70.00% 69.97% -0.04%
==========================================
Files 33 33
Lines 1867 1865 -2
==========================================
- Hits 1307 1305 -2
Misses 560 560
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from Stenberg himself in curl/curl#5717, it doesn't really make much sense to set both
nobodyanduploadon the same request in order to fulfill weird HEAD requests with a request body. Change (and simplify) to usenobodyfor normal HEAD requests, andupload+customrequestotherwise.