Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add static-ssl feature to mirror curl/static-ssl #225

Merged
merged 1 commit into from
Sep 23, 2020
Merged

add static-ssl feature to mirror curl/static-ssl #225

merged 1 commit into from
Sep 23, 2020

Conversation

Mythra
Copy link
Contributor

@Mythra Mythra commented Sep 21, 2020

I have some builds that I'd like to have produce a fully static binary, and for that I need to expose curl/static-ssl. I think for the general case having it dynamically linked is fine (I mean no one has complained thus far!), so I've left it out of the default features for now, but would be happy to add it there if you feel it's worth it.

Thanks!

@Mythra Mythra requested a review from sagebind as a code owner September 21, 2020 14:10
@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4e662f0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #225   +/-   ##
=========================================
  Coverage          ?   70.33%           
=========================================
  Files             ?       37           
  Lines             ?     2090           
  Branches          ?        0           
=========================================
  Hits              ?     1470           
  Misses            ?      620           
  Partials          ?        0           
Impacted Files Coverage Δ
src/text.rs 70.68% <0.00%> (ø)
tests/timeouts.rs 84.61% <0.00%> (ø)
tests/request_body.rs 100.00% <0.00%> (ø)
src/request.rs 80.00% <0.00%> (ø)
src/cookies/psl/mod.rs 83.33% <0.00%> (ø)
test-util/src/mock.rs 68.75% <0.00%> (ø)
tests/methods.rs 100.00% <0.00%> (ø)
tests/response_body.rs 100.00% <0.00%> (ø)
src/metrics.rs 24.39% <0.00%> (ø)
src/auth.rs 59.37% <0.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e662f0...cbef04e. Read the comment docs.

@Mythra
Copy link
Contributor Author

Mythra commented Sep 21, 2020

Hmmm Not sure why ubuntu-latest test failed, seemed to fail on something I didn't touch? Flake?

@sagebind
Copy link
Owner

Sorry about that, I'll take a look at CI tonight and figure out why it is failing.

Thanks for the PR though!

Copy link
Owner

@sagebind sagebind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good addition. 👍

@sagebind sagebind merged commit 1db4c87 into sagebind:master Sep 23, 2020
@sagebind
Copy link
Owner

Indeed it looks like one test has recently become flaky, but just on Ubuntu CI. I'll have to dig into that separately, but that's neither here nor there. 😉

I'll release this as version 0.9.9 so that you can start using it shortly.

@Mythra
Copy link
Contributor Author

Mythra commented Sep 23, 2020

Thanks so much!

@sagebind
Copy link
Owner

A wild 0.9.9 has appeared! https://github.com/sagebind/isahc/releases/tag/0.9.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants