-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add static-ssl feature to mirror curl/static-ssl #225
Conversation
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
=========================================
Coverage ? 70.33%
=========================================
Files ? 37
Lines ? 2090
Branches ? 0
=========================================
Hits ? 1470
Misses ? 620
Partials ? 0
Continue to review full report at Codecov.
|
Hmmm Not sure why ubuntu-latest test failed, seemed to fail on something I didn't touch? Flake? |
Sorry about that, I'll take a look at CI tonight and figure out why it is failing. Thanks for the PR though! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good addition. 👍
Indeed it looks like one test has recently become flaky, but just on Ubuntu CI. I'll have to dig into that separately, but that's neither here nor there. 😉 I'll release this as version 0.9.9 so that you can start using it shortly. |
Thanks so much! |
A wild 0.9.9 has appeared! https://github.com/sagebind/isahc/releases/tag/0.9.9 |
I have some builds that I'd like to have produce a fully static binary, and for that I need to expose
curl/static-ssl
. I think for the general case having it dynamically linked is fine (I mean no one has complained thus far!), so I've left it out of the default features for now, but would be happy to add it there if you feel it's worth it.Thanks!