Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Connection Cache TTL #237

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Add Connection Cache TTL #237

merged 1 commit into from
Oct 15, 2020

Conversation

gsquire
Copy link
Contributor

@gsquire gsquire commented Oct 14, 2020

This patch uses the newly exposed curl configuration allowing for a client to set up a connection cache TTL.

Closes #93

This patch uses the newly exposed curl configuration allowing for a
client to set up a connection cache TTL.
@gsquire gsquire requested a review from sagebind as a code owner October 14, 2020 04:55
@gsquire
Copy link
Contributor Author

gsquire commented Oct 14, 2020

Sorry, I think rustfmt made a few changes to the style. I can revert those chunks if you would like.

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #237 into master will decrease coverage by 0.24%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   71.09%   70.85%   -0.25%     
==========================================
  Files          44       44              
  Lines        2128     2134       +6     
==========================================
- Hits         1513     1512       -1     
- Misses        615      622       +7     
Impacted Files Coverage Δ
src/config/mod.rs 61.81% <0.00%> (-1.15%) ⬇️
src/client.rs 64.67% <28.57%> (-1.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d56d33...62bab7e. Read the comment docs.

Copy link
Owner

@sagebind sagebind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for working on this!

Don't worry about the formatting too much, it isn't a problem. One of these days I'll add a rustfmt config file if I cared about being consistent...

@sagebind sagebind merged commit cf662a4 into sagebind:master Oct 15, 2020
@gsquire gsquire deleted the max-age branch October 17, 2020 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set TTL for connection pool
2 participants