Skip to content

Commit

Permalink
Require Python 3.9
Browse files Browse the repository at this point in the history
build with Python 3.8 seems to fail with

```
In file included from /home/conda/feedstock_root/build_artifacts/cypari2_1705557903378/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/python3.8/pytime.h:6,
                   from /home/conda/feedstock_root/build_artifacts/cypari2_1705557903378/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/include/python3.8/Python.h:85,
                   from cypari2/convert.c:50:
  cypari2/pycore_long.h: In function '_PyLong_SetSignAndDigitCount':
  cypari2/pycore_long.h:92:13: error: 'o' undeclared (first use in this function); did you mean 'op'?
     92 |     Py_SIZE(o) = size;
        |
```

also our CI only tests with Python 3.9+ so that seem to be required by
now.

In any case, active support for Python 3.8 ended May 2021 and security
support is going to end in October 2024.
  • Loading branch information
Matthias Koeppe committed Mar 16, 2024
1 parent 1d06b56 commit c011b3e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Requirements:
https://doc.sagemath.org/html/en/reference/spkg/pari#spkg-pari
for availability in distributions (GNU/Linux, conda-forge, Homebrew, FreeBSD),
or install from source.
- Python >= 3.6
- Python >= 3.9
- pip

Install cypari2 via the Python Package Index (PyPI) via
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ authors = [
dependencies = [
"cysignals>=1.7",
]
requires-python = ">=3.9"
readme = "README.rst"
license = {text = "GNU General Public License, version 2 or later"}
keywords = ["PARI/GP number theory"]
Expand Down

0 comments on commit c011b3e

Please sign in to comment.