Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added python 3.11 workflow #7

Merged
merged 11 commits into from
Jun 2, 2022
Merged

added python 3.11 workflow #7

merged 11 commits into from
Jun 2, 2022

Conversation

kliem
Copy link
Collaborator

@kliem kliem commented May 18, 2022

This tests (and shall eventually fix) #6

@kliem
Copy link
Collaborator Author

kliem commented May 18, 2022

Just trying to copy from zeromq/pyzmq#1657.

@kliem kliem force-pushed the fix_python_3_11 branch from 1d94b8a to 4bbc098 Compare May 18, 2022 10:11
@kliem
Copy link
Collaborator Author

kliem commented May 19, 2022

I was able to reproduce the failure here: kliem#1.

So maybe it makes sense to force the version of the dependencies for the workflow, so that we will see incompatibilities.

@mkoeppe What do you think. Make a prerelease and test it with https://trac.sagemath.org/ticket/33842?

@mkoeppe
Copy link

mkoeppe commented May 19, 2022

Make a prerelease and test it with https://trac.sagemath.org/ticket/33842?

Yes, sounds good

@kliem
Copy link
Collaborator Author

kliem commented May 19, 2022

A bit of testing is useful. Turns out that cython version 0.29.28 does not suffice, but 0.29.30 is needed.

@kliem
Copy link
Collaborator Author

kliem commented May 21, 2022

@videlec
This pull request also raises required cython version to 0.29.30.
I guess one could also do a conditional requirement as explained here:
https://peps.python.org/pep-0631/#example

This would then be something like?
requires = ["setuptools", "wheel", "Cython", 'Cython>=0.29.30; python_version > "3.10"']

@videlec
Copy link
Contributor

videlec commented May 21, 2022

Indeed. Ubuntu 20.04 ships Python 3.8.2 and Cython 0.29.4. It seems safe to only have the Cython requirement for Python version > 3.10.

@kliem kliem merged commit 9a814b7 into main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants