Skip to content

Commit

Permalink
Trac #34421: Fix timeout in jupyter_jsmol installation
Browse files Browse the repository at this point in the history
after #33866 update, I get an error on Gentoo.

As it turns out, jupyter_jsmol installation process fetches more js
stuff than there is in the tarball:
{{{
jjupyter_jsmol-2022.1.0] Building wheels for collected packages:
jupyter-jsmol
[jupyter_jsmol-2022.1.0]   WARNING: Ignoring --build-option when
building jupyter-jsmol using PEP 517
[jupyter_jsmol-2022.1.0]   Building wheel for jupyter-jsmol
(pyproject.toml): started
[jupyter_jsmol-2022.1.0]   Running command Building wheel for jupyter-
jsmol (pyproject.toml)
[jupyter_jsmol-2022.1.0]   setup.py entered
[jupyter_jsmol-2022.1.0]   $PATH=/mnt/opt/Sage/sage-
dev/build/bin:/mnt/opt/Sage/sage-dev/local/var/lib/sage/venv-
python3.10/bin:/mnt/opt/Sage/sage-dev/local/bin:/mnt/opt/Sage/sage-
dev/build/bin:/mnt/opt/Sage/sage-dev/local/bin:/mnt/opt/Sage/sage-
dev/local/var/lib/sage/venv-python3.10/bin:/mnt/opt/Sage/sage-
dev/build/bin:/mnt/opt/Sage/sage-dev/src/bin:/mnt/opt/Sage/sage-dev/loca
l/bin:/home/dima/.elan/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr
/bin:/sbin:/bin:/opt/bin:/usr/lib/llvm/14/bin:/home/dima/.local/bin:/hom
e/dima/.local/bin
[jupyter_jsmol-2022.1.0]   <string>:47: DeprecatedWarning:
create_cmdclass is deprecated as of 0.8 and will be removed in 1.0. "
[jupyter_jsmol-2022.1.0]   Use `wrap_installers` to handle prebuild
steps in cmdclass.
[jupyter_jsmol-2022.1.0]   Use `get_data_files` to handle data files.
[jupyter_jsmol-2022.1.0]   Use `include_package_data=True` and
`MANIFEST.in` for package data.
[jupyter_jsmol-2022.1.0]
[jupyter_jsmol-2022.1.0]   <string>:49: DeprecatedWarning: install_npm
is deprecated as of 0.8 and will be removed in 1.0. Use `npm_builder`
and `wrap_installers`
[jupyter_jsmol-2022.1.0]   running bdist_wheel
[jupyter_jsmol-2022.1.0]   running jsdeps
[jupyter_jsmol-2022.1.0]   Installing build dependencies with npm.  This
may take a while...
[jupyter_jsmol-2022.1.0]   > yarn install
[jupyter_jsmol-2022.1.0]   yarn install v1.22.19
[jupyter_jsmol-2022.1.0]   warning package.json: No license field
[jupyter_jsmol-2022.1.0]   warning package-lock.json found. Your project
contains lock files generated by tools other than Yarn. It is advised
not to mix package managers in order to avoid resolution inconsistencies
caused by unsynchronized lock files. To clear this warning, remove
package-lock.json.
[jupyter_jsmol-2022.1.0]   warning jupyter-jsmol@2022.1.0: No license
field
[jupyter_jsmol-2022.1.0]   [1/4] Resolving packages...
[jupyter_jsmol-2022.1.0]   [2/4] Fetching packages...
[jupyter_jsmol-2022.1.0]   info There appears to be trouble with your
network connection. Retrying...
...
}}}

and it hangs - even tough the network is OK.
Also reported [https://groups.google.com/g/sage-devel/c/emnDzvu5vR4 on
sage-devel] with Arch Linux.

A straight `./sage --pip install jupyter_jsmol` is almost instant
success.

URL: https://trac.sagemath.org/34421
Reported by: dimpase
Ticket author(s): Matthias Koeppe
Reviewer(s): Dima Pasechnik
  • Loading branch information
Release Manager committed Aug 28, 2022
2 parents bed45ff + 6fb910f commit a5bf710
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion build/pkgs/jupyter_jsmol/spkg-install.in
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
cd src
eval sdh_pip_install $(eval sdh_prefix_args "--build-option" build --skip-npm) .
# Use --no-build-isolation because we have a different version of jupyter_packaging
eval sdh_pip_install --no-build-isolation --config-settings "--global-option=--skip-npm" .

0 comments on commit a5bf710

Please sign in to comment.