Skip to content

Commit

Permalink
Trac #34442: Set version upper bound for setuptools: <64.0
Browse files Browse the repository at this point in the history
From @saraedum on zulip:
 I am building SageMath from source following the guide that uses conda
packages. I find that pip install --no-build-isolation -v -v --editable
src always recompiles all the extension modules.

As a fix for Sage 9.7, we set an upper bound for setuptools that
excludes the new editable wheels feature introduced in 64.0.0. See
#34344, #34209 for follow-ups

URL: https://trac.sagemath.org/34442
Reported by: mkoeppe
Ticket author(s): Matthias Koeppe
Reviewer(s): Julian Rüth
  • Loading branch information
Release Manager committed Aug 28, 2022
2 parents 24a6ab4 + 8ff3894 commit ee070f2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
5 changes: 4 additions & 1 deletion build/pkgs/setuptools/distros/conda.txt
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
setuptools
# Set this bound until https://trac.sagemath.org/ticket/34209 adds support for PEP660 editable builds
# By setting this version bound, we avoid having to include the following in our installation instructions.
# export SETUPTOOLS_ENABLE_FEATURES=legacy-editable
"setuptools<64"
3 changes: 2 additions & 1 deletion build/pkgs/setuptools/install-requires.txt
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
setuptools >=49.6.0
# Set this bound until https://trac.sagemath.org/ticket/34209 adds support for PEP660 editable builds
setuptools >=49.6.0,<64.0.0

0 comments on commit ee070f2

Please sign in to comment.