pAdicZZpXCAElement can not be initialized from fraction field element

[saraedum]

Currently, the following code fails:

sage: R = ZpCA(3,5)
sage: S.<T> = R[]
sage: W.<a> = R.extension(T^2-3)
sage: W(W.fraction_field().zero())
TypeError: Cannot convert sage.rings.padics.padic_ZZ_pX_CR_element.pAdicZZpXCRElement to sage.rings.padics.padic_ZZ_pX_CA_element.pAdicZZpXCAElement

The attached patch fixes this.

Component: padics

Author: Julian Rueth

Reviewer: David Roe

Merged: sage-5.8.beta1

Issue created by migration from https://trac.sagemath.org/ticket/13600

[saraedum]

comment:1

The following two lines cause the problem:

        cdef pAdicZZpXCAElement _x
[...] 
                _x = <pAdicZZpXCRElement>x 

[saraedum]

comment:2

I also did a little bit of cleanup regarding traling whitespace. Tried to make the AUTHORS conform to the developer's guide. I hope the reviewer doesn't mind that I put these things into the patch.

[roed314]

comment:3

Looks good to me. I'm happy to give it a positive review once it passes doctests.

[saraedum]

Attachment: trac_13600.patch.gz

[roed314]

comment:4

Is this ready for review?

[roed314]

Reviewer: David Roe

[tscrim]

comment:6

If this is ready for review, please set it to needs_review.

[roed314]

comment:8

Looks good.