- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New implementation of unramified p-adics using FLINT and templates #14304
Comments
comment:3
This ticket is essentially complete at https://github.com/saraedum/sage/tree/Zq. Once #12173 is positively reviewed we'll make some patches and put this up for review. |
comment:6
The repository moved to https://github.com/saraedum/sage-renamed/tree/Zq |
Commit: |
Branch: u/saraedum/Zq |
Changed branch from u/saraedum/Zq to u/roed/ticket/14304 |
Reviewer: David Roe, Julian Rueth |
Author: Julian Rueth, David Roe |
comment:12
I mostly looked at the last two commits. Everything else had already been reviewed before. I did not run doctests. Is there a working patchbot which will run the doctests or do I have to run them manually? |
comment:13
Does not work... please run "make ptestlong" |
comment:14
Will do. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:95
Needs to be rebased on top of #20210. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:98
Okay, I think I rebased it, but there are a ton of doctest errors that have nothing to do with p-adics. I'm not sure what's going on.
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:101
Ok, I think I fixed the problems. |
comment:102
I'm getting the same list of doctests failing. They don't fail on #20210. This is weird. I did a clean pull and tested them. None of them seem to have anything to do with your patch. Are they passing for you? |
comment:103
I think mine are passing. See Prec_Build.term on the project.... |
comment:104
I updated my development branch and now everything is passing. It looks good to me! :) |
Changed keywords from sd59 to sd59, sd71 |
Changed reviewer from David Roe, Julian Rueth to David Roe, Julian Rueth, Aly Deines |
Changed keywords from sd59, sd71 to sd59, days71 |
Changed reviewer from David Roe, Julian Rueth, Aly Deines to David Roe, Julian Rüth, Aly Deines |
Changed author from Julian Rueth, David Roe to Julian Rüth, David Roe |
comment:107
(I was told to be consistent about my last name…) |
Changed branch from public/14304 to |
Reimplement Qq using FLINT.
Depends on #20210
CC: @fredrik-johansson @jpflori @saraedum
Component: padics
Keywords: sd59, days71
Author: Julian Rüth, David Roe
Branch/Commit:
56b357c
Reviewer: David Roe, Julian Rüth, Aly Deines
Issue created by migration from https://trac.sagemath.org/ticket/14304
The text was updated successfully, but these errors were encountered: