Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New implementation of unramified p-adics using FLINT and templates #14304

Closed
roed314 opened this issue Mar 19, 2013 · 137 comments
Closed

New implementation of unramified p-adics using FLINT and templates #14304

roed314 opened this issue Mar 19, 2013 · 137 comments

Comments

@roed314
Copy link
Contributor

roed314 commented Mar 19, 2013

Reimplement Qq using FLINT.

Depends on #20210

CC: @fredrik-johansson @jpflori @saraedum

Component: padics

Keywords: sd59, days71

Author: Julian Rüth, David Roe

Branch/Commit: 56b357c

Reviewer: David Roe, Julian Rüth, Aly Deines

Issue created by migration from https://trac.sagemath.org/ticket/14304

@roed314 roed314 added this to the sage-5.11 milestone Mar 19, 2013
@roed314 roed314 self-assigned this Mar 19, 2013
@roed314
Copy link
Contributor Author

roed314 commented Mar 22, 2013

comment:3

This ticket is essentially complete at https://github.com/saraedum/sage/tree/Zq. Once #12173 is positively reviewed we'll make some patches and put this up for review.

@jdemeyer
Copy link

jdemeyer commented May 9, 2013

comment:5

Replying to @roed314:

Once #12173 is positively reviewed

check!

@saraedum
Copy link
Member

comment:6

The repository moved to https://github.com/saraedum/sage-renamed/tree/Zq

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@roed314
Copy link
Contributor Author

roed314 commented Jan 5, 2014

Commit: ed8db42

@roed314
Copy link
Contributor Author

roed314 commented Jan 5, 2014

Branch: u/saraedum/Zq

@roed314
Copy link
Contributor Author

roed314 commented Jan 5, 2014

Last 10 new commits:

ed8db42fixup
244b3a8conversion from finite fields
8f255a9fix some typos
65d3c03added matrix_mod_pn
ff52ce0removed FLINT skip
7b2ad9afixed a doctest
fd2ea9fadded flint rep
13a2d60added an _new_fmpz_poly method
52010f3switched to powcomputer_
02ffe57disabled tests for FLINT

@roed314
Copy link
Contributor Author

roed314 commented Jan 5, 2014

Changed branch from u/saraedum/Zq to u/roed/ticket/14304

@roed314
Copy link
Contributor Author

roed314 commented Jan 5, 2014

New commits:

e7afa8fImproved some_elements()
ef18f02Adding some docstrings, fixing a few typos.

@roed314
Copy link
Contributor Author

roed314 commented Jan 5, 2014

Changed commit from ed8db42 to e7afa8f

@roed314
Copy link
Contributor Author

roed314 commented Jan 5, 2014

Reviewer: David Roe, Julian Rueth

@roed314
Copy link
Contributor Author

roed314 commented Jan 5, 2014

Author: Julian Rueth, David Roe

@saraedum
Copy link
Member

saraedum commented Jan 6, 2014

comment:12

I mostly looked at the last two commits. Everything else had already been reviewed before. I did not run doctests. Is there a working patchbot which will run the doctests or do I have to run them manually?

@vbraun
Copy link
Member

vbraun commented Jan 7, 2014

comment:13

Does not work... please run "make ptestlong"

@roed314
Copy link
Contributor Author

roed314 commented Jan 7, 2014

comment:14

Will do.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 7, 2014

Changed commit from e7afa8f to 98a4529

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 7, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

98a4529Fix doctest errors

@jdemeyer
Copy link

comment:95

Needs to be rebased on top of #20210.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 22, 2016

Changed commit from baca192 to c22ae81

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 22, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

03458eaUpgrade cysignals package
dce67fcMove memory functions to cysignals
4bb8337Rename sage_malloc -> sig_malloc and friends
c22ae81Merge commit '4bb8337295ed82c93d1a9c9f7173a4c3' into t/14304/ticket/14304

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 22, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

a14ee5dFixing imports and name changes due to switch to cysignals

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 22, 2016

Changed commit from c22ae81 to a14ee5d

@roed314
Copy link
Contributor Author

roed314 commented Mar 22, 2016

comment:98

Okay, I think I rebased it, but there are a ton of doctest errors that have nothing to do with p-adics. I'm not sure what's going on.

sage -t src/sage/combinat/root_system/root_lattice_realizations.py  # 1 doctest failed
sage -t src/sage/combinat/designs/database.py  # 2 doctests failed
sage -t src/sage/geometry/polyhedron/base.py  # 2 doctests failed
sage -t src/sage/graphs/generic_graph.py  # 94 doctests failed
sage -t src/sage/graphs/graph.py  # 46 doctests failed
sage -t src/sage/doctest/forker.py  # 1 doctest failed
sage -t src/sage/schemes/generic/algebraic_scheme.py  # 10 doctests failed
sage -t src/sage/graphs/generators/smallgraphs.py  # 18 doctests failed
sage -t src/sage/tests/cmdline.py  # 14 doctests failed
sage -t src/sage/structure/sage_object.pyx  # 4 doctests failed
sage -t src/sage/combinat/rigged_configurations/rigged_configuration_element.py  # 1 doctest failed
sage -t src/sage/schemes/toric/points.py  # 1 doctest failed
sage -t src/sage/combinat/posets/posets.py  # 5 doctests failed
sage -t src/sage/interfaces/sage0.py  # 1 doctest failed
sage -t src/sage/combinat/designs/orthogonal_arrays.py  # 8 doctests failed
sage -t src/sage/graphs/generators/families.py  # 4 doctests failed
sage -t src/sage/geometry/cone.py  # 3 doctests failed
sage -t src/sage/combinat/rigged_configurations/rigged_configurations.py  # 1 doctest failed
sage -t src/sage/combinat/designs/orthogonal_arrays_build_recursive.py  # 13 doctests failed
sage -t src/sage/matroids/matroid.pyx  # 1 doctest failed
sage -t src/sage/repl/interpreter.py  # 22 doctests failed
sage -t src/sage/structure/misc.pyx  # 1 doctest failed
sage -t src/sage/combinat/designs/incidence_structures.py  # 10 doctests failed
sage -t src/sage/numerical/optimize.py  # 6 doctests failed
sage -t src/sage/combinat/rigged_configurations/rc_infinity.py  # 1 doctest failed
sage -t src/sage/graphs/comparability.pyx  # 6 doctests failed
sage -t src/sage/graphs/generators/basic.py  # 1 doctest failed
sage -t src/sage/repl/ipython_extension.py  # 9 doctests failed
sage -t src/sage/repl/attach.py  # 2 doctests failed
sage -t src/sage/graphs/digraph.py  # 4 doctests failed
sage -t src/sage/typeset/ascii_art.py  # 2 doctests failed
sage -t src/sage/numerical/mip.pyx  # 486 doctests failed
sage -t src/sage/tests/french_book/nonlinear_doctest.py  # 1 doctest failed
sage -t src/sage/interacts/debugger.py  # 1 doctest failed
sage -t src/sage/repl/display/formatter.py  # 10 doctests failed
sage -t src/sage/combinat/designs/bibd.py  # 19 doctests failed
sage -t src/sage/repl/inputhook.pyx  # 2 doctests failed
sage -t src/sage/misc/temporary_file.py  # 1 doctest failed
sage -t src/sage/doctest/test.py  # 1 doctest failed
sage -t src/sage/repl/interface_magic.py  # 3 doctests failed
sage -t src/sage/dev/trac_interface.py  # 1 doctest failed
sage -t src/doc/en/thematic_tutorials/lie/infinity_crystals.rst  # 1 doctest failed
sage -t src/sage/combinat/posets/poset_examples.py  # 1 doctest failed
sage -t src/sage/repl/ipython_tests.py  # 4 doctests failed
sage -t src/sage/combinat/designs/orthogonal_arrays_find_recursive.pyx  # 2 doctests failed
sage -t src/sage/graphs/graph_decompositions/vertex_separation.pyx  # 7 doctests failed
sage -t src/sage/numerical/backends/glpk_backend.pyx  # 470 doctests failed
sage -t src/sage/combinat/integer_vector.py  # 5 doctests failed
sage -t src/sage/numerical/linear_functions.pyx  # 212 doctests failed
sage -t src/sage/combinat/rigged_configurations/rc_crystal.py  # 1 doctest failed
sage -t src/sage/combinat/shard_order.py  # 1 doctest failed
sage -t src/sage/graphs/generators/degree_sequence.py  # 3 doctests failed
sage -t src/sage/repl/rich_output/backend_ipython.py  # 3 doctests failed
sage -t src/sage/numerical/linear_tensor_element.pyx  # 50 doctests failed
sage -t src/doc/en/thematic_tutorials/numerical_sage/weave.rst  # 1 doctest failed
sage -t src/sage/numerical/linear_tensor_constraints.py  # 46 doctests failed
sage -t src/sage/numerical/backends/cvxopt_backend.pyx  # 10 doctests failed
sage -t src/sage/numerical/linear_tensor.py  # 57 doctests failed
sage -t src/sage/repl/ipython_kernel/install.py  # 1 doctest failed
sage -t src/sage/graphs/generators/chessboard.py  # 1 doctest failed
sage -t src/doc/en/reference/sat/index.rst  # 4 doctests failed
sage -t src/sage/numerical/backends/generic_backend.pyx  # 1 doctest failed
sage -t src/sage/graphs/graph_coloring.py  # 17 doctests failed
sage -t src/sage/numerical/knapsack.py  # 5 doctests failed
sage -t src/sage/graphs/hypergraph_generators.py  # 1 doctest failed
sage -t src/sage/repl/ipython_kernel/kernel.py  # 4 doctests failed
sage -t src/doc/en/thematic_tutorials/linear_programming.rst  # 35 doctests failed
sage -t src/sage/sat/solvers/sat_lp.py  # 15 doctests failed
sage -t src/sage/graphs/graph_decompositions/cutwidth.pyx  # 9 doctests failed
sage -t src/sage/graphs/convexity_properties.pyx  # 4 doctests failed
sage -t src/sage/sat/solvers/satsolver.pyx  # 1 doctest failed
sage -t src/sage/numerical/backends/gurobi_backend.pyx  # 1 doctest failed

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 22, 2016

Changed commit from a14ee5d to 56b357c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 22, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

56b357cFixing some more pxi includes

@roed314
Copy link
Contributor Author

roed314 commented Mar 22, 2016

comment:101

Ok, I think I fixed the problems.

@adeines
Copy link
Mannequin

adeines mannequin commented Mar 22, 2016

comment:102

I'm getting the same list of doctests failing. They don't fail on #20210. This is weird. I did a clean pull and tested them. None of them seem to have anything to do with your patch. Are they passing for you?

@roed314
Copy link
Contributor Author

roed314 commented Mar 22, 2016

comment:103

I think mine are passing. See Prec_Build.term on the project....

@adeines
Copy link
Mannequin

adeines mannequin commented Mar 23, 2016

comment:104

I updated my development branch and now everything is passing. It looks good to me! :)

@adeines
Copy link
Mannequin

adeines mannequin commented Mar 23, 2016

Changed keywords from sd59 to sd59, sd71

@adeines
Copy link
Mannequin

adeines mannequin commented Mar 23, 2016

Changed reviewer from David Roe, Julian Rueth to David Roe, Julian Rueth, Aly Deines

@adeines
Copy link
Mannequin

adeines mannequin commented Mar 23, 2016

Changed keywords from sd59, sd71 to sd59, days71

@saraedum
Copy link
Member

Changed reviewer from David Roe, Julian Rueth, Aly Deines to David Roe, Julian Rüth, Aly Deines

@saraedum
Copy link
Member

Changed author from Julian Rueth, David Roe to Julian Rüth, David Roe

@saraedum
Copy link
Member

comment:107

(I was told to be consistent about my last name…)

@vbraun
Copy link
Member

vbraun commented Mar 23, 2016

Changed branch from public/14304 to 56b357c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants