Add FLINT declarations for finite fields and p-adics

[jdemeyer]

Add the declarations for #14304 and #16664.

CC: @roed314 @jpflori @saraedum

Component: interfaces

Author: Julian Rueth, David Roe, Jean-Pierre Flori, Jeroen Demeyer

Branch: 6cc4151

Reviewer: Jean-Pierre Flori

Issue created by migration from https://trac.sagemath.org/ticket/19646

[jdemeyer]

Branch: u/jdemeyer/ticket/19646

[jdemeyer]

New commits:

75bd5ec

Add FLINT declarations for finite fields and p-adics

[jdemeyer]

Commit: 75bd5ec

[jdemeyer]

comment:3

This ticket is mostly just copying stuff from #14304 and #16664. I did add a few more changes, so somebody should still look at the branch.

[jpflori]

comment:4

Thanks for splitting this out of the other tickets.
A note on the fq bindings, could you add the fq_div functions?
They were mysteriously left out of the release when I started #16664, but should be in now.

[jdemeyer]

comment:5

Replying to @jpflori:

Thanks for splitting this out of the other tickets.
A note on the fq bindings, could you add the fq_div functions?
They were mysteriously left out of the release when I started #16664, but should be in now.

I saw them commented out, so I didn't know what to do with them.

Note that there was no need to comment them out in the first place: it's not a problem to declare functions which don't actually exist. You will get a compiler error when you use them, but not if you just declare them.

[jdemeyer]

comment:6

There is still no fq_nmod_div...

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2fa8600

Add fq_div()

[sagetrac-git]

Changed commit from 75bd5ec to 2fa8600

[jpflori]

comment:8

Yes indeed...
And I see

FLINT_DLL void fq_div(fq_t rop, const fq_t op1, const fq_t op2, const fq_ctx_t ctx);
FLINT_DLL void fq_sqr(fq_t rop, const fq_t op, const fq_ctx_t ctx);
FLINT_DLL void fq_div(fq_t rop, const fq_t op1, const fq_t op2, const fq_ctx_t ctx);
FLINT_DLL void fq_sqr(fq_t rop, const fq_t op, const fq_ctx_t ctx);

in the trunk version of fq.h.
I'll make a pull request upstream.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

6cc4151

Use standard copyright template

[sagetrac-git]

Changed commit from 2fa8600 to 6cc4151

[jpflori]

Reviewer: Jean-Pierre Flori

[jdemeyer]

comment:11

Thanks!

[vbraun]

Changed branch from u/jdemeyer/ticket/19646 to 6cc4151

[jpflori]

Changed commit from 6cc4151 to none

[jpflori]

comment:13

Actually there is a fq_nmod_div prototype which gets defined through the inclusion of fq_templates.h.