-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable optional rollback functionality when upgrading packages #25202
Comments
Replying to @embray:
Just FYI in case you didn't know: our release manager is one of the main contributors to hashdist. The project looks pretty dead though: the last commit on github was 2 years ago. |
comment:2
Replying to @jdemeyer:
I know. I tried using it a while ago to build Sage on Cygwin and had some problems due to a lack of Cygwin-specific patches for a number of dependencies that needed to be ported over. Other than that, a few other details I had quibbles with, the way it works makes a lot of sense and I'm surprised Volker didn't push more to get Sage using it. I would have... |
comment:5
Retargeting some of my tickets (somewhat optimistically for now). |
comment:6
Removing most of the rest of my open tickets out of the 8.7 milestone, which should be closed. |
With #25139 it becomes possible to fully uninstall all files associated with a package, which is done before upgrading that package to a new version.
This would just as easily allow creating a backup of the package by moving its files to a temporary location rather than deleting them. If the package upgrade fails, the old version could then be restored.
One could even imagine keeping backups that can be restored even after a seemingly successful upgrade (e.g. the upgrade succeeds building, but causes runtime regressions). One could easily get carried away with something like this though and end up re-implementing hashdist (which honestly wouldn't be such a bad thing to have built into Sage...).
But to keep things focused I think this ticket should just consider rollback on build failures to start with.
Depends on #25139
Component: build
Issue created by migration from https://trac.sagemath.org/ticket/25202
The text was updated successfully, but these errors were encountered: