-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade: Singular 4.2.0, pysingular 0.9.7 #25993
Comments
Dependencies: #24735 |
This comment has been minimized.
This comment has been minimized.
Branch: u/jdemeyer/ticket/25993 |
This comment has been minimized.
This comment has been minimized.
Commit: |
Last 10 new commits:
|
comment:5
Sigh. So I have to upgrade the group cohomology package earlier than I thought. I'll see what I can do (after grading some exam). |
comment:6
The ticket description prominently tells that the group cohomology package is failing, but the title of the ticket is about upgrading Singular. So, just to be sure about the topic of this ticket:
|
Replying to @jdemeyer:
Most likely it is an API change. |
comment:8
This ticket is about upgrading Singular. If the p_group_cohomology package must be changed, ideally it should be done in a way which makes it compatible both with Singular 4.1.1p3 as well as earlier versions. In that case, the upgrade of p_group_cohomology can be done on a different ticket and #25993 should depend on that. Concerning the commit history, only the last commit belongs to this ticket. The rest belongs to #24735 which is an upgrade of Singular to 4.1.1p2. |
comment:10
PS: I recently added a patch to Singular which backports a bugfix that is important to me. Is that bugfix in Singular-4.1.1? |
comment:11
Replying to @simon-king-jena:
I know that it does not occur. That's also a good reason to do the upgrade in two steps: first to 4.1.1p2 which works fine and then to 4.1.1p3 (or a later version) once p_group_cohomology is fixed. |
comment:12
Replying to @jdemeyer:
Thank you! That sounds like a good plan. And do you know about the backported bug fix? |
comment:13
Replying to @simon-king-jena:
That's hard to say if you don't say which patch you mean. In any case, all patches which are currently (in Sage 8.3.rc3) applied to Singular are included in Singular 4.1.1p2. Note that you said 4.1.1 but I guess you really care about 4.1.1p2 or 4.1.1p3. Despite what the version numbers suggest, experience shows that Singular adds non-trivial changes in such patch-releases. |
comment:14
Replying to @jdemeyer:
It is
I see. I thought that the "p something" patch level is Sage's addition of patches, not Singular's. |
Upstream: Fixed upstream, but not in a stable release. |
This comment has been minimized.
This comment has been minimized.
comment:16
Replying to @simon-king-jena:
No, Sage's p levels have a dot. So you can have a Singular package version number like |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:18
Replying to @simon-king-jena:
Sorry, I don't know what you mean. Where should I find this patch? |
comment:19
Replying to @jdemeyer:
|
comment:20
Replying to @simon-king-jena:
At least this time, it's not the fault of Sage but Singular :-) |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:200
Replying to @mkoeppe:
I'll have to make do with that. It also looks like I missed the 4.2.0_p1 release. Question. Apart from the windows packaging stuff, is there any major change to take into account past 4.2.0_p1? As in, can a linux packager use 4.2.0_p1 and expect it to work? New commits:
|
comment:201
Replying to @mkoeppe:
I disagree. The commit hash is also a certificate. Tags can be changed. |
comment:202
Replying to @kiwifb:
Well, I hope upstream will merge a version of my latest PR. You need it to build the documentation. |
comment:203
Replying to @kiwifb:
I don't know. |
comment:204
Replying to @mkoeppe:
Well, I'll let people know on this ticket if I found out first. This may be important for detecting whether a system singular can be used. |
comment:205
Replying to @kiwifb:
Everything works fine with upstream 4.2.0_p1 and the sagelib changes in this ticket. Only caveat is that you need to install singular.idx manually. |
comment:206
Is |
comment:207
Replying to @antonio-rojas:
Thanks, I thought that you could know already :) I already patch for singular.idx installation, nothing new there. |
comment:208
Replying to @mkoeppe:
No, it is just not (no longer?) installed by make install. |
comment:209
This should probably be wrapped for readability |
Changed reviewer from Matthias Koeppe, https://github.com/mkoeppe/sage/actions/runs/655556434 (cygwin), https://github.com/mkoeppe/sage/actions/runs/655556443 (linux/macos) to Matthias Koeppe, Dima Pasechnik |
comment:210
I am happy to see this through. |
comment:211
Thanks! |
Changed branch from public/singular4-1-3 to |
Changed keywords from upgrade, Singular to upgrade, Singular, pysingular |
Changed commit from |
comment:214
Upstream has now merged all pull requests. |
Changed upstream from Reported upstream. Developers acknowledge bug. to Fixed upstream, but not in a stable release. |
comment:216
Follow up in #31552 |
Tarball:
see checksums.ini
on the branchUse
make SAGE_SPKG="sage-spkg -o" singular-clean sagelib-clean build
to automatically download and install."Critical" because it enables supporting newer versions of FLINT.
We use the Singular development branch (
spielwiese
) + PR Singular/Singular#1058 in order to build documentation. The tarball is made from https://github.com/mkoeppe/Singular/tree/Release-4-2-0-p1%2BsageUpstream: Fixed upstream, but not in a stable release.
CC: @simon-king-jena @timokau @slel @isuruf @saraedum @dkrenn @sagetrac-araichev @cheuberg @behackl @dimpase @videlec
Component: packages: standard
Keywords: upgrade, Singular, pysingular
Author: Antonio Rojas, Markus Wageringel, Matthias Koeppe
Branch:
ec471e0
Reviewer: Matthias Koeppe, Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/25993
The text was updated successfully, but these errors were encountered: