Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sdh_cmake for packages that use cmake #27486

Closed
embray opened this issue Mar 14, 2019 · 9 comments
Closed

Use sdh_cmake for packages that use cmake #27486

embray opened this issue Mar 14, 2019 · 9 comments

Comments

@embray
Copy link
Contributor

embray commented Mar 14, 2019

#27484 adds an sdh_cmake helper function for use by our handful of (all currently optional/experimental) packages. We should try updating those packages to use the new helper:

Of these, only scipoptsuite is somewhat unusual in that it does a sort of VPATH build in that it cds into a build/ directory and then runs cmake ... This is incompatible with the current implementation of sdh_cmake. So for that package either we don't use sdh_cmake, or forego the use of the build/ directory, which may not be necessary anyways.

CC: @embray @jdemeyer

Component: packages: optional

Author: Frédéric Chapoton

Branch/Commit: 1df46ef

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/27486

@embray embray added this to the sage-8.8 milestone Mar 14, 2019
@dimpase
Copy link
Member

dimpase commented Mar 19, 2019

comment:1

neither qhull nor cryptominisat try to install anything in lib64 or so, thus it's really not that urgent to fix.

@fchapoton
Copy link
Contributor

Branch: u/chapoton/27486

@fchapoton
Copy link
Contributor

Commit: 1df46ef

@fchapoton
Copy link
Contributor

New commits:

1df46efusing cmake for qhull and cryptominisat

@fchapoton
Copy link
Contributor

comment:3

please have a look

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@dimpase
Copy link
Member

dimpase commented May 29, 2019

comment:4

looks good to me

@dimpase
Copy link
Member

dimpase commented May 29, 2019

Reviewer: Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented Jun 2, 2019

Changed branch from u/chapoton/27486 to 1df46ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants