Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sdh_cmake for configuring primecount #27485

Closed
embray opened this issue Mar 14, 2019 · 12 comments
Closed

Use sdh_cmake for configuring primecount #27485

embray opened this issue Mar 14, 2019 · 12 comments
Labels
c: packages: optional p: major / 3 t: bug
Milestone
sage-8.7

Comments

@embray
Copy link
Contributor

embray commented Mar 14, 2019

This resolves the issue reported at https://groups.google.com/d/msg/sage-devel/w6Os2s6_eGk/SyFxT7cJBgAJ that the primecount SPKG will try to install libraries to lib64 on some platforms.

Depends on #27484

CC: @videlec @dimpase

Component: packages: optional

Author: Erik Bray

Branch: b244e65

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/27485
@embray embray added this to the sage-8.8 milestone Mar 14, 2019
@embray
Copy link
Contributor Author

embray commented Mar 14, 2019

Branch: u/embray/build/primecount/sdh-cmake

@embray
Copy link
Contributor Author

embray commented Mar 14, 2019

comment:1

I sort-of confirmed this negatively by modifying sdh_make to set CMAKE_INSTALL_LIBDIR=lib64 which caused it to fail. Setting it back to "lib" works, so I'm assuming that explicitly setting CMAKE_INSTALL_LIBDIR should work in general.

New commits:

b0fa3a0Trac #27484: Add shd_cmake helper for running cmake with the correct flags for
b244e65Trac #27485: Use sdh_cmake in the spkg-install for primecount.

@embray
Copy link
Contributor Author

embray commented Mar 14, 2019

Commit: b244e65

@embray
Copy link
Contributor Author

embray commented Mar 14, 2019

Author: Erik Bray

@dimpase
Copy link
Member

dimpase commented Mar 14, 2019

comment:2

LGTM, tested with primecount.

@dimpase
Copy link
Member

dimpase commented Mar 14, 2019

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Mar 14, 2019

comment:3

Did you look at other cmake-dependent packages?

$ grep cmake build/pkgs/*/de*
build/pkgs/cryptominisat/dependencies:$(PYTHON) m4ri zlib libpng | cmake sqlite boost_cropped
build/pkgs/primecount/dependencies:cmake
build/pkgs/qhull/dependencies:| cmake
build/pkgs/scipoptsuite/dependencies:$(MP_LIBRARY) bliss readline | cmake

@embray
Copy link
Contributor Author

embray commented Mar 14, 2019

comment:4

I already opened #27486 for that.

@vbraun
Copy link
Member

vbraun commented Mar 15, 2019

Changed branch from u/embray/build/primecount/sdh-cmake to b244e65

@vbraun vbraun closed this as completed in eb8d110 Mar 15, 2019
@embray
Copy link
Contributor Author

embray commented Mar 18, 2019

comment:6

So is the milestone for this 8.8 or 8.7?

@embray
Copy link
Contributor Author

embray commented Mar 18, 2019

Changed commit from b244e65 to none

@dimpase
Copy link
Member

dimpase commented Mar 18, 2019

comment:7

github insider info - it's 8.7 ;-)

@dimpase dimpase modified the milestones: sage-8.8, sage-8.7 Mar 18, 2019
@embray embray mentioned this issue Jun 2, 2019
Closed
dkrenn added a commit to dkrenn/sage that referenced this issue May 25, 2023
@dkrenn
Merge branch 'u/dkrenn/sequences/rec-hash' into u/dkrenn/sequences/k-…
4e7f615 
…regular-guess

* u/dkrenn/sequences/rec-hash: (8211 commits)
  Updated SageMath version to 8.7
  Updated SageMath version to 8.7.rc0
  Trac sagemath#27490: Moved the alternate build_many implementation into a sage_setup.docbuild.utils module.
  Trac sagemath#27490: Further fixes in use of os.wait()
  Trac sagemath#27214: Patch GAP to allocate its memory pool using MAP_NORESERVE on Cygwin
  Trac sagemath#27490: Address some review comments and other cleanup:
  A little bit of import cleanup
  Trac sagemath#27490: Simplistic multiprocessing.Pool replacement for parallel docbuild on older Cygwin
  Fix alarm() test when cysignals was compiled with debugging
  Trac sagemath#27485: Use sdh_cmake in the spkg-install for primecount.
  Trac sagemath#27484: Add shd_cmake helper for running cmake with the correct flags for building Sage SPKGs.
  cysignals should be a normal dependency
  Upgrade to Cysignals 1.10.2
  Upgrade to notebook-5.7.6
  Trac sagemath#27461: Add abs tol on this test to account for minor numerical difference on Cygwin due to libm differences.
  Replacing None < infinity comparison with equivalent code.
  Some last little tidbits for uniformity.
  Removing some code duplication for __pth_root (changed to _pth_root_func).
  One more xderinv added.
  trac 27474: move some references to the master bibliography file.
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge branch 'u/dkrenn/sequences/k-regular-guess' into u/dkrenn/k-reg…
3b0f9d0 
…ular-warning

* u/dkrenn/sequences/k-regular-guess: (8211 commits)
  Updated SageMath version to 8.7
  Updated SageMath version to 8.7.rc0
  Trac sagemath#27490: Moved the alternate build_many implementation into a sage_setup.docbuild.utils module.
  Trac sagemath#27490: Further fixes in use of os.wait()
  Trac sagemath#27214: Patch GAP to allocate its memory pool using MAP_NORESERVE on Cygwin
  Trac sagemath#27490: Address some review comments and other cleanup:
  A little bit of import cleanup
  Trac sagemath#27490: Simplistic multiprocessing.Pool replacement for parallel docbuild on older Cygwin
  Fix alarm() test when cysignals was compiled with debugging
  Trac sagemath#27485: Use sdh_cmake in the spkg-install for primecount.
  Trac sagemath#27484: Add shd_cmake helper for running cmake with the correct flags for building Sage SPKGs.
  cysignals should be a normal dependency
  Upgrade to Cysignals 1.10.2
  Upgrade to notebook-5.7.6
  Trac sagemath#27461: Add abs tol on this test to account for minor numerical difference on Cygwin due to libm differences.
  Replacing None < infinity comparison with equivalent code.
  Some last little tidbits for uniformity.
  Removing some code duplication for __pth_root (changed to _pth_root_func).
  One more xderinv added.
  trac 27474: move some references to the master bibliography file.
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge tag '8.7' into u/dkrenn/joint-spectral-radius
4025684 
SageMath version 8.7, Release Date: 2019-03-23

* tag '8.7': (943 commits)
  Updated SageMath version to 8.7
  Updated SageMath version to 8.7.rc0
  Trac sagemath#27490: Moved the alternate build_many implementation into a sage_setup.docbuild.utils module.
  Trac sagemath#27490: Further fixes in use of os.wait()
  Trac sagemath#27214: Patch GAP to allocate its memory pool using MAP_NORESERVE on Cygwin
  Trac sagemath#27490: Address some review comments and other cleanup:
  A little bit of import cleanup
  Trac sagemath#27490: Simplistic multiprocessing.Pool replacement for parallel docbuild on older Cygwin
  Fix alarm() test when cysignals was compiled with debugging
  Trac sagemath#27485: Use sdh_cmake in the spkg-install for primecount.
  Trac sagemath#27484: Add shd_cmake helper for running cmake with the correct flags for building Sage SPKGs.
  cysignals should be a normal dependency
  Upgrade to Cysignals 1.10.2
  Upgrade to notebook-5.7.6
  Trac sagemath#27461: Add abs tol on this test to account for minor numerical difference on Cygwin due to libm differences.
  Replacing None < infinity comparison with equivalent code.
  Some last little tidbits for uniformity.
  Removing some code duplication for __pth_root (changed to _pth_root_func).
  One more xderinv added.
  trac 27474: move some references to the master bibliography file.
  ...
dkrenn added a commit to dkrenn/sage that referenced this issue Aug 3, 2023
@dkrenn
Merge branch 'u/dkrenn/k-regular-warning' into u/galipnik/k-regular-b…
9dfa1b3 
…ounded

* u/dkrenn/k-regular-warning: (8211 commits)
  Updated SageMath version to 8.7
  Updated SageMath version to 8.7.rc0
  Trac sagemath#27490: Moved the alternate build_many implementation into a sage_setup.docbuild.utils module.
  Trac sagemath#27490: Further fixes in use of os.wait()
  Trac sagemath#27214: Patch GAP to allocate its memory pool using MAP_NORESERVE on Cygwin
  Trac sagemath#27490: Address some review comments and other cleanup:
  A little bit of import cleanup
  Trac sagemath#27490: Simplistic multiprocessing.Pool replacement for parallel docbuild on older Cygwin
  Fix alarm() test when cysignals was compiled with debugging
  Trac sagemath#27485: Use sdh_cmake in the spkg-install for primecount.
  Trac sagemath#27484: Add shd_cmake helper for running cmake with the correct flags for building Sage SPKGs.
  cysignals should be a normal dependency
  Upgrade to Cysignals 1.10.2
  Upgrade to notebook-5.7.6
  Trac sagemath#27461: Add abs tol on this test to account for minor numerical difference on Cygwin due to libm differences.
  Replacing None < infinity comparison with equivalent code.
  Some last little tidbits for uniformity.
  Removing some code duplication for __pth_root (changed to _pth_root_func).
  One more xderinv added.
  trac 27474: move some references to the master bibliography file.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
3 participants
@embray @vbraun @dimpase